Skip to content

Static constructor clarifications #23562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2021
Merged

Static constructor clarifications #23562

merged 1 commit into from
Mar 31, 2021

Conversation

@tdykstra
Copy link
Contributor

Fixes #20432
Fixes #10243

@tdykstra tdykstra requested a review from BillWagner as a code owner March 30, 2021 23:11
@dotnet-bot dotnet-bot added this to the April 2021 milestone Mar 30, 2021
BillWagner
BillWagner approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @tdykstra

You can :shipit: when ready.

@tdykstra tdykstra merged commit b37f6e1 into dotnet:main Mar 31, 2021
@tdykstra tdykstra deleted the staticctor branch March 31, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees

No one assigned

Labels

dotnet-csharp/svc fundamentals/subsvc

Projects

None yet

Milestone

April 2021

Development

Successfully merging this pull request may close these issues.

"Implicit static constructor" terminology is inaccurate and causes confusion Are static constructors thread-safe?

3 participants

@tdykstra @BillWagner @dotnet-bot