Fixed smart quotes #2147
Merged
Fixed smart quotes #2147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svick
commented
May 13, 2017
| @@ -27,7 +27,7 @@ Specifies the discoverability of service endpoints. | |||
| ## Syntax | |||
|
|
|||
| ``` | |||
| <behaviors> <serviceBehaviors> <behavior name=String"> <serviceDiscovery> <announcementEndpoints> <endpoint name="String” kind="Type" /> </announcementEndpoints> <discoveryEndpoints> <endpoint name="String” kind="Type" /> </discoveryEndpoints> </serviceDiscovery> </behavior> </serviceBehaviors></behaviors> | |||
| <behaviors> <serviceBehaviors> <behavior name=String"> <serviceDiscovery> <announcementEndpoints> <endpoint name="String" kind="Type" /> </announcementEndpoints> <discoveryEndpoints> <endpoint name="String" kind="Type" /> </discoveryEndpoints> </serviceDiscovery> </behavior> </serviceBehaviors></behaviors> | |||
There was a problem hiding this comment.
There's quite a lot of XML code blocks formatted terribly like this one.
They will need to be fixed in a separate PR.
| @@ -61,7 +61,7 @@ Registers a claims authentication manager for the incoming claims. | |||
|
|
|||
| ``` | |||
| \<system.identityModel> | |||
| \<identityConfiguration name=”MyIdentity”> | |||
| \<identityConfiguration name="MyIdentity"> | |||
| <claimsAuthenticationManager type="MyNamespace.CustomClaimsAuthenticationManager, MyAssembly"/> | |||
| </identityConfiguration> | |||
| \</microsoft.identityModel> | |||
There was a problem hiding this comment.
There are also some XML code blocks like this one with incorrect escaping.
guardrex
approved these changes
May 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of these changes fix code, most are just about using a uniform style.