-
Notifications
You must be signed in to change notification settings - Fork 6k
Removing "see remarks" language #2032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update Update Update
I like this change. @rpetrusha what do you think? We could check if we have that in value or exception @guardrex, if Ron agrees. |
Yes, there are uses of "see remarks" language in both |
@mairaw @rpetrusha Last commit removes "see remarks" lingo from It's ready for another look. 👀 |
@guardrex, is this ready to merge? If sop, there are two merge conflicts that have to be resolved. |
@rpetrusha Sure .... I'll square those away right now. |
Unfortunately, @guardrex, there are additional merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. You can merge it when you want, @guardrex.
Fixes #2031
Per #2003 (comment): Language for "see remarks" in various forms are in dozens of files for
<summary>
,<param>
, and<returns>
. This PR removes that language.@rpetrusha @mairaw Do we also need to remove this language from
<value>
and/or<exception>
tags?