Skip to content

F# plaintext printing documentation #19632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 78 commits into from
Aug 4, 2020
Merged

F# plaintext printing documentation #19632

merged 78 commits into from
Aug 4, 2020

Conversation

dsyme
Copy link
Contributor

@dsyme dsyme commented Jul 22, 2020

Summary

Adds information to the F# language guide on structured plaintext printing in F# and the mechanisms available to customize it

cc @cartermp

(@cartermp - separately, we should add a page on printf in general)

@dsyme dsyme requested a review from cartermp as a code owner July 22, 2020 13:00
@dotnet-bot dotnet-bot added this to the July 2020 milestone Jul 22, 2020
@dsyme dsyme mentioned this pull request Jul 22, 2020
Open
Youssef1313
Youssef1313 reviewed Jul 22, 2020
View reviewed changes
Youssef1313
Youssef1313 reviewed Jul 22, 2020
View reviewed changes
dsyme and others added 2 commits July 22, 2020 16:37
@dsyme @Youssef1313
Update docs/fsharp/language-reference/plaintext-formatting.md
cb774e1 
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
@dsyme @Youssef1313
Update docs/fsharp/language-reference/fsharp-interactive-options.md
7c58838 
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
cartermp
cartermp suggested changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first quick review pass

dsyme and others added 6 commits July 22, 2020 17:58
@dsyme @cartermp
Update docs/fsharp/language-reference/plaintext-formatting.md
22d5d7a 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@dsyme @cartermp
Update docs/fsharp/language-reference/plaintext-formatting.md
0d4c566 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@dsyme @cartermp
Update docs/fsharp/language-reference/fsharp-interactive-options.md
a62c18e 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@dsyme @cartermp
Update docs/fsharp/language-reference/fsharp-interactive-options.md
28b3dbe 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@dsyme @cartermp
Update docs/fsharp/language-reference/fsharp-interactive-options.md
2a73064 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@dsyme @cartermp
Update docs/fsharp/language-reference/plaintext-formatting.md
d0e394f 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
Youssef1313
Youssef1313 requested changes Jul 22, 2020
View reviewed changes
Copy link
Member

@Youssef1313 Youssef1313 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styling changes. You may need until it's reviewed before committing them.

dsyme and others added 13 commits July 22, 2020 18:42
@dsyme @cartermp
Update docs/fsharp/language-reference/plaintext-formatting.md
2ed567c 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@dsyme @cartermp
Update docs/fsharp/language-reference/plaintext-formatting.md
3e315a6 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@dsyme @Youssef1313
Update docs/fsharp/language-reference/fsharp-interactive-options.md
a30abea 
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
@dsyme @Youssef1313
Update docs/fsharp/language-reference/fsharp-interactive-options.md
f7b7cf7 
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
@dsyme @Youssef1313
Update docs/fsharp/language-reference/fsharp-interactive-options.md
081e138 
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
@dsyme @Youssef1313
Update docs/fsharp/language-reference/fsharp-interactive-options.md
35b695e 
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
@dsyme @Youssef1313
Update docs/fsharp/language-reference/plaintext-formatting.md
dd05c96 
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
@dsyme @Youssef1313
Update docs/fsharp/language-reference/plaintext-formatting.md
b144740 
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
@dsyme @Youssef1313
Update docs/fsharp/language-reference/fsharp-interactive-options.md
24c6173 
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
@dsyme @Youssef1313
Update docs/fsharp/language-reference/plaintext-formatting.md
1521b93 
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
@dsyme @Youssef1313
Update docs/fsharp/language-reference/plaintext-formatting.md
4b5e57d 
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
@dsyme @Youssef1313
Update docs/fsharp/language-reference/plaintext-formatting.md
1de04e9 
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
@dsyme @Youssef1313
Update docs/fsharp/language-reference/fsharp-interactive-options.md
7e21846 
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
@cartermp
Copy link
Contributor

cartermp commented Aug 4, 2020

@dsyme I recommend looking at the remaining suggestions from @gewarren , such as here: https://github.com/dotnet/docs/pull/19632/files#r463183291

I could see these subtitles being either. I would prefer not starting with %A in them if possible.

cartermp
cartermp reviewed Aug 4, 2020
View reviewed changes
dsyme and others added 17 commits August 4, 2020 03:51
@dsyme @gewarren
Update docs/fsharp/language-reference/plaintext-formatting.md
1e20bb0 
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@dsyme @gewarren
Update docs/fsharp/language-reference/plaintext-formatting.md
c3f48b1 
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@dsyme @gewarren
Update docs/fsharp/language-reference/plaintext-formatting.md
0d3a1f1 
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@dsyme @cartermp
Update docs/fsharp/language-reference/plaintext-formatting.md
1545463 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@dsyme @gewarren
Update docs/fsharp/language-reference/plaintext-formatting.md
0257abb 
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@dsyme @cartermp
Update docs/fsharp/language-reference/plaintext-formatting.md
d46d1c8 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@dsyme @cartermp
Update docs/fsharp/language-reference/plaintext-formatting.md
8e34ab8 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@dsyme @gewarren
Update docs/fsharp/language-reference/plaintext-formatting.md
1be9163 
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@dsyme @cartermp
Update docs/fsharp/language-reference/plaintext-formatting.md
41e0ae6 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@dsyme @cartermp
Update docs/fsharp/language-reference/plaintext-formatting.md
7c17936 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@dsyme @cartermp
Update docs/fsharp/language-reference/plaintext-formatting.md
035ab50 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@dsyme @cartermp
Update docs/fsharp/language-reference/plaintext-formatting.md
ff561d0 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@dsyme @cartermp
Update docs/fsharp/language-reference/plaintext-formatting.md
e2e9597 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@dsyme @cartermp
Update docs/fsharp/language-reference/plaintext-formatting.md
6110a82 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@dsyme @cartermp
Update docs/fsharp/language-reference/plaintext-formatting.md
1e3c523 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@dsyme @cartermp
Update docs/fsharp/language-reference/plaintext-formatting.md
512cdc9 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@dsyme @cartermp
Update docs/fsharp/language-reference/plaintext-formatting.md
a456db9 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@dsyme
Copy link
Contributor Author

dsyme commented Aug 4, 2020

@cartermp Cool thanks, I've been through and accepted them now

cartermp
cartermp approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending these changes!

dsyme and others added 2 commits August 4, 2020 04:21
@dsyme @cartermp
Update docs/fsharp/language-reference/fsharp-interactive-options.md
301ef8e 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@dsyme @cartermp
Update docs/fsharp/language-reference/fsharp-interactive-options.md
9fd796d 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@dsyme
Copy link
Contributor Author

dsyme commented Aug 4, 2020

Have I got them all now? :-)

@cartermp cartermp requested a review from gewarren August 4, 2020 03:25
@cartermp
Copy link
Contributor

cartermp commented Aug 4, 2020

Yeeeee

@cartermp cartermp merged commit a61b508 into dotnet:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 requested changes

@cartermp cartermp cartermp approved these changes

@gewarren gewarren gewarren approved these changes

@BillWagner BillWagner Awaiting requested review from BillWagner

Assignees
No one assigned
Labels
dotnet-fsharp/svc
Projects
None yet
Milestone
July 2020
Development

Successfully merging this pull request may close these issues.
6 participants
@dsyme @cartermp @gewarren @Youssef1313 @BillWagner @dotnet-bot