Update language identifiers and styleguide. #1796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tompratt-AQ, |
mairaw
requested changes
Mar 24, 2017
| @@ -25,7 +25,7 @@ The key concept to understand is that an async expression’s type is `Async<'T> | |||
|
|
|||
| For example, say you wanted to download the HTML from dotnetfoundation.org without blocking the main thread. You can accomplish it like this: | |||
|
|
|||
| ```fs | |||
| ```fsharpharp | |||
There was a problem hiding this comment.
should be fsharp only. maybe search your working branch to see if you have other instances of fsharpharp or csharpharp
| @@ -40,7 +40,7 @@ translation.priority.ht: | |||
| # Static Classes and Static Class Members (C# Programming Guide) | |||
| A [static](../../../csharp/language-reference/keywords/static.md) class is basically the same as a non-static class, but there is one difference: a static class cannot be instantiated. In other words, you cannot use the [new](../../../csharp/language-reference/keywords/new.md) keyword to create a variable of the class type. Because there is no instance variable, you access the members of a static class by using the class name itself. For example, if you have a static class that is named `UtilityClass` that has a public method named `MethodA`, you call the method as shown in the following example: | |||
|
|
|||
| ```cs | |||
| ```csharp | |||
| UtilityClass.MethodA(); | |||
| ``` | |||
There was a problem hiding this comment.
the snippet below this one is missing the identifier. please add.
There was a problem hiding this comment.
I fixed these two issues and did not find any other instances like these.
mairaw
approved these changes
Mar 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Update language identifiers and style guide for supported languages.
Summary
Added a list of supported languages with language IDs and markdown labels to the style guide. Fixed language identifiers for C#, F# and PHP in all files to match the supported markdown labels.
Fixes #1737
Suggested Reviewers
@mairaw