Skip to content

Updates for latest design #1775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2017
Merged

Updates for latest design #1775

merged 1 commit into from
Mar 24, 2017

Conversation

jasongroce
Copy link
Contributor

Updates to images for hub page

The design team has provided new images for this hub page; the original ones were placeholders until the icon designer came to the team.

Summary

There are 21 updated SVG files, and the index.md file had to be updated to:

  • Use a different card style (with images above instead of to the side)
  • Apply the background accent style to images in the new card style

Suggested Reviewers

@mairaw

@jasongroce
Copy link
Contributor Author

@mairaw Can you take a look at this? The design team created new images for the hub, and then they also wanted to modify the card style to accommodate these. I don't know what your release schedule is like, but I just wanted to be able to provide a potential ETA to Design on this. Thanks!

@mairaw
Copy link
Contributor

mairaw commented Mar 24, 2017

Sorry @jasongroce. I've been super busy. I can review this now.

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @nokura FYI, the hub page is changing design.

@mairaw mairaw merged commit 8cd0b51 into dotnet:master Mar 24, 2017
openpublishtest pushed a commit to openpublishtest/docs that referenced this pull request Mar 24, 2017
@jasongroce
Copy link
Contributor Author

Thanks @mairaw !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants