Skip to content

Building .NET Core solutions using Visual Studio for Mac #1744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 20, 2017
Merged

Building .NET Core solutions using Visual Studio for Mac #1744

merged 16 commits into from
Mar 20, 2017

Conversation

guardrex
Copy link
Contributor

@guardrex guardrex commented Mar 17, 2017

Fixes #1743

Notes

  • Minor change to windows prepreqs in passing here
  • Prereqs section: No single bullet there on one prereq unless you want it. I'm not a big fan of the single bullet list. Let me know.
  • Took my liberties with the unit test part. IMO there's no super-fast way to do it. I didn't want to only do a Fact or skip to only a Theory. By the time you do both, it extends the experience to the max for a introductory tutorial. However in defense of this approach, there isn't enough unit testing in the world imo. Devs prob need to see how easy and useful they are.
  • On the ASP.NET Core side, we did put links to open GH work issues for missing features. I did that here with the bit on the test runner not working in VS for Mac. I can pull that line if you like. If the line stays, I'm monitoring that issue, and I'll submit a PR to remove it and update the text/images when they get it fixed.
  • ... and this one was a real pleasure. 😀 I like Macs, and I don't get enough time to mess around with my Mac Mini. It performed beautifully here! Tip of the 🎩 to Apple! 🍻

@guardrex guardrex added this to the March 2017 milestone Mar 17, 2017
@guardrex guardrex self-assigned this Mar 17, 2017
@dnfclas
Copy link

dnfclas commented Mar 17, 2017

@guardrex,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@guardrex
Copy link
Contributor Author

cc/ @bleroy -- If you're reviewing, the drafts are finished.

@BillWagner BillWagner removed the WIP label Mar 20, 2017
@BillWagner
Copy link
Member

I reviewed everything, and it LGTM.
@bleroy Do you want to review as well, or should we :shipit:?

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read through everything, and have no issues.

@bleroy
Copy link
Contributor

bleroy commented Mar 20, 2017

I did give it a look, and it looks good to me.

@guardrex
Copy link
Contributor Author

Thanks guys ..... all new content here and my first time using the Mac with .NET Core, so I greatly appreciate the 👀 on it.

@bleroy
Copy link
Contributor

bleroy commented Mar 20, 2017

@BillWagner @mairaw I suppose the only question I would have is not about this PR specifically, but about what happened to the VS Mac work I did a few months ago (see https://github.com/dotnet/docs/commits/vs-mac-golden-path) as I can't find this in the current TOC.

@BillWagner
Copy link
Member

@bleroy I'm going to defer to @mairaw on that one.

@BillWagner BillWagner merged commit 14fc782 into dotnet:master Mar 20, 2017
@guardrex guardrex deleted the guardrex/vs-for-mac branch March 20, 2017 21:39
@guardrex
Copy link
Contributor Author

@bleroy This was a rather extensive rewrite starting with the direction you took. Elements of what you did come thru here, and I thank you for that and the docs on this PR benefit greatly from your work.

@guardrex guardrex removed this from the March 2017 milestone Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building .NET Core solutions using Visual Studio for Mac
4 participants