Skip to content

Revert "fix casing of curl ssl option" #17001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

am11
Copy link
Member

@am11 am11 commented Feb 6, 2020

Reverts #16576

-sSL option (with single hyphen) is the short form of -s, --silent, -S, --show-error, -L, --location, so cURL can follow redirects. Not to be confused with --ssl, which only tells the lib to "try SSL"; we do not need to specify it with HTTPS URLs.

Reference manual: cURL(1)

@scottaddie scottaddie merged commit 166b3c7 into dotnet:master Feb 7, 2020
@scottaddie
Copy link
Member

Thank you for bringing this to our attention, @am11!

@am11 am11 deleted the revert-16576-scottaddie/curl-ssl-casing branch February 7, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants