VS2017 Getting Started doc updates #1679

guardrex · 2017-03-08T20:23:36Z

(Attempting a squashed commits version here.)

Notes

Still rough! Ruf! Ruf! 🐕 Even after review and merge, I'd like to come back in a week or two and work these a bit more.
New images! ... but more needed in a few spots. Let's not hold it up tho just for a couple that I can add later.
Propose we keep the old images in the media folder. They might be linked into other docs. After all docs in this area have dedicated static asset folders for their images, we can delete all of the images in the media folder safely.
If there are more docs that need updating under Review topics that use Visual Studio 2017 RC #1480, I can do those, but I suppose not holding up the whole 🌏 planet 🌍 for these would be good.
@mairaw I don't think you added the red stroke outlines to the images you did for VS2017 RTM initial update #1663. I got it covered ... I opened Add stroke outlines to images #1675 for it.

I'll remove the WIP label after the build runs and I fix any broken links.

I'll ping when it's ready for a 👀 look 👀.

dnfclas · 2017-03-08T20:23:40Z

@guardrex,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

guardrex · 2017-03-08T23:05:26Z

docs/csharp/getting-started/debugging-with-visual-studio-2017.md


-1. Let's try to change the value of the variables to see how this affects our program. If the **Immediate window** is not visible, display it by choosing the **Debug**, **Windows**, **Immediate** menu item. The **Immediate window** lets you interact with the application you're debugging.
+1. You can change the value of the variables to see how it affects your program. If the **Immediate Window** is not visible, display it by choosing the **Debug > Windows > Immediate** menu item. The **Immediate Window** lets you interact with the application you're debugging.


choosing 👉 selecting

guardrex · 2017-03-08T23:11:57Z

.openpublishing.redirection.json

+        "redirect_document_id": true
+    },
+    {
+        "source_path": "docs/csharp/getting-started/debugging-with-visual-studio-2017.md", 


remove this redirect .... this one had to stay the same

I couldn't rename that one (or the publishing one). The debugging-with-visual-studio.md and the publishing-with-visual-studio.md are 301 redirecting.

Did you want to ignore that and move the content over to those files anyway?

Double-301? ... If a proxy or a system has a cached 301 on the non-2017 address and they request the 2017-version of the doc ... it then 301's back to the non-2017 doc. Hum. 🤔
EDIT: Should be ok. I expect a cache update when the 301 goes back (I hope).

guardrex · 2017-03-08T23:12:27Z

.openpublishing.redirection.json

+        "redirect_document_id": true
+    },
+    {
+        "source_path": "docs/csharp/getting-started/publishing-with-visual-studio-2017.md", 


remove this redirect .... this one had to stay the same

mairaw

I haven't finished my review, but so far, so good!

mairaw · 2017-03-09T02:55:11Z

docs/csharp/getting-started/library-with-visual-studio.md

+
+1. On the Visual Studio menu bar, choose **File > New > Project**.
+
+1. In the **New Project** dialog, expand the **Other Project Types** node, and select **Visual Studio Solutions**. Name the solution "ClassLibraryProjects" and select the **OK** button.


should the project name be inline code?

I was trying to follow the existing pattern where if the user is directed to type something the text is in quotes. In other places, the project name is in-line code.

That's a good point.

mairaw · 2017-03-09T02:57:36Z

docs/csharp/getting-started/library-with-visual-studio.md

+
+## Next step
+
+You've successfully built the library. Because you haven't called any of its methods, you don't know whether it works as expected. The next step in developing your library is to test it by using a [C# Unit Test Project](testing-library-with-visual-studio.md).


wondering if we also should start adding the Prev and Next buttons

BillWagner · 2017-04-17T20:34:50Z

@guardrex Can you update the merge conflicts here as well?

guardrex · 2017-04-17T22:23:23Z

@BillWagner Conflicts seem* to be fixed.

seem* = I better go back over the changes one more time and see how the report looks after the build finishes. I'll remove the WIP label and ping you when ready.

guardrex · 2017-04-18T04:20:55Z

@BillWagner ready for 👀

Update toc.md Update index.md Update testing-library-with-visual-studio.md Update debugging-with-visual-studio.md Update index.md Update publishing-with-visual-studio-2017.md Update consuming-library-with-visual-studio-2017.md Update with-visual-studio-2017.md Update libraries-with-vs.md Update .openpublishing.redirection.json Update publishing-with-visual-studio.md Update debugging-with-visual-studio-2017.md Create consuming-library-with-visual-studio.md Delete consuming-library-with-visual-studio-2017.md Update debugging-with-visual-studio.md Update toc.md Update index.md Update index.md Update publishing-with-visual-studio-2017.md Update consuming-library-with-visual-studio.md Update with-visual-studio-2017.md Create library-with-visual-studio.md Delete library-with-visual-studio-2017.md Update publishing-with-visual-studio.md Update toc.md Update index.md Update index.md Update consuming-library-with-visual-studio.md Update with-visual-studio-2017.md Update debugging-with-visual-studio-2017.md Update consuming-library-with-visual-studio.md Update debugging-with-visual-studio-2017.md Update consuming-library-with-visual-studio.md Update library-with-visual-studio.md Update publishing-with-visual-studio-2017.md Update library-with-visual-studio.md Create new_project.png Add files via upload Update library-with-visual-studio.md Add files via upload Delete class_library.png Add files via upload Delete class_library.png Add files via upload Update library-with-visual-studio.md Create use-library.png Delete build_succeeded.png Delete lib_project.png Delete new_project.png Delete string_library.png Create newproject.png Add files via upload Update library-with-visual-studio.md Update consuming-library-with-visual-studio.md Add files via upload Delete buildsucceeded.png Add files via upload Update library-with-visual-studio.md Update consuming-library-with-visual-studio.md Create debugmode.png Add files via upload Update debugging-with-visual-studio-2017.md Create toolbar1.png Add files via upload Update publishing-with-visual-studio-2017.md Delete publish2.png Delete toolbar1.png Add files via upload Update publishing-with-visual-studio-2017.md Update publishing-with-visual-studio-2017.md Create testproject.png Add files via upload Update testing-library-with-visual-studio.md Delete uittestwindow.png Add files via upload Update library-with-visual-studio.md Update consuming-library-with-visual-studio.md Update consuming-library-with-visual-studio.md Update consuming-library-with-visual-studio.md Update consuming-library-with-visual-studio.md Update consuming-library-with-visual-studio.md Update debugging-with-visual-studio-2017.md Update debugging-with-visual-studio-2017.md Update debugging-with-visual-studio-2017.md Update debugging-with-visual-studio-2017.md Update debugging-with-visual-studio-2017.md Update debugging-with-visual-studio-2017.md Update debugging-with-visual-studio-2017.md Update debugging-with-visual-studio-2017.md Update debugging-with-visual-studio-2017.md Update debugging-with-visual-studio-2017.md Update debugging-with-visual-studio-2017.md Update debugging-with-visual-studio-2017.md Update debugging-with-visual-studio-2017.md Update debugging-with-visual-studio-2017.md Update debugging-with-visual-studio-2017.md Update debugging-with-visual-studio-2017.md Update debugging-with-visual-studio-2017.md Update consuming-library-with-visual-studio.md Update library-with-visual-studio.md Update publishing-with-visual-studio-2017.md Update testing-library-with-visual-studio.md Update testing-library-with-visual-studio.md Update testing-library-with-visual-studio.md Update testing-library-with-visual-studio.md Update testing-library-with-visual-studio.md Update testing-library-with-visual-studio.md Update testing-library-with-visual-studio.md Update testing-library-with-visual-studio.md Update testing-library-with-visual-studio.md Update testing-library-with-visual-studio.md Update testing-library-with-visual-studio.md Update testing-library-with-visual-studio.md Update debugging-with-visual-studio-2017.md Update testing-library-with-visual-studio.md Update getting-started.md Update toc.md

BillWagner

Looks good overall. I'd agree with @mairaw that the Prev and Next buttons would be useful for readers. Adding them would be a good idea, but not a blocker to merging.

…ed-updates

dnfclas added the cla-already-signed label Mar 8, 2017

guardrex commented Mar 8, 2017

View reviewed changes

guardrex added Area - Conceptual Docs labels Mar 8, 2017

guardrex added this to the March 2017 milestone Mar 8, 2017

guardrex self-assigned this Mar 8, 2017

guardrex mentioned this pull request Mar 9, 2017

Update with-visual-studio.md #1686

Merged

mairaw reviewed Mar 9, 2017

View reviewed changes

mairaw removed this from the March 2017 milestone Mar 29, 2017

guardrex mentioned this pull request Mar 29, 2017

C# Guide: Getting Started with Visual Studio #943

Closed

guardrex changed the title ~~VS2017 Getting Started doc updates~~ [WIP] VS2017 Getting Started doc updates Apr 17, 2017

guardrex added the WIP label Apr 17, 2017

guardrex changed the title ~~[WIP] VS2017 Getting Started doc updates~~ VS2017 Getting Started doc updates Apr 18, 2017

guardrex removed the WIP label Apr 18, 2017

guardrex and others added 8 commits April 21, 2017 12:50

Update .openpublishing.redirection.json

2a8b967

Update getting-started.md

826f6cf

Move remaining 2017 docs

8f23f3b

Updates

4e3a49e

Updates

c1ab50f

Updates

214d078

Minor update

20e5db8

BillWagner approved these changes May 2, 2017

View reviewed changes

Merge branch 'master' into GuardRex-guardrex/vs2017-rtm-getting-start…

ad9848e

…ed-updates

guardrex merged commit 22aab46 into dotnet:master May 3, 2017

guardrex deleted the GuardRex-guardrex/vs2017-rtm-getting-started-updates branch May 3, 2017 05:51


		1. Let's try to change the value of the variables to see how this affects our program. If the Immediate window is not visible, display it by choosing the Debug, Windows, Immediate menu item. The Immediate window lets you interact with the application you're debugging.
		1. You can change the value of the variables to see how it affects your program. If the Immediate Window is not visible, display it by choosing the Debug > Windows > Immediate menu item. The Immediate Window lets you interact with the application you're debugging.


		1. On the Visual Studio menu bar, choose File > New > Project.

		1. In the New Project dialog, expand the Other Project Types node, and select Visual Studio Solutions. Name the solution "ClassLibraryProjects" and select the OK button.


		## Next step

		You've successfully built the library. Because you haven't called any of its methods, you don't know whether it works as expected. The next step in developing your library is to test it by using a [C# Unit Test Project](testing-library-with-visual-studio.md).

VS2017 Getting Started doc updates #1679

VS2017 Getting Started doc updates #1679

Uh oh!

Conversation

guardrex commented Mar 8, 2017

Uh oh!

dnfclas commented Mar 8, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

guardrex Mar 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mairaw left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BillWagner commented Apr 17, 2017

Uh oh!

guardrex commented Apr 17, 2017

Uh oh!

guardrex commented Apr 18, 2017

Uh oh!

BillWagner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

guardrex Mar 9, 2017 •

edited

Loading