Update test library for VS 2019 #16371

mairaw · 2019-12-21T02:49:55Z

Contributes to #16046

gewarren

LG with a couple suggestions.

docs/core/tutorials/testing-library-with-visual-studio.md

gewarren · 2019-12-23T21:11:25Z

docs/core/tutorials/testing-library-with-visual-studio.md


   [!code-csharp[Test#1](~/samples/snippets/csharp/getting_started/with_visual_studio_2017/testlib1.cs)]
+   [!code-vb[Test#1](~/samples/snippets/core/tutorials/vb-library-with-visual-studio/testlib.vb)]

   Note that your test of uppercase characters in the `TestStartsWithUpper` method includes the Greek capital letter alpha (U+0391) and the Cyrillic capital letter EM (U+041C), and the test of lowercase characters in the `TestDoesNotStartWithUpper` method includes the Greek small letter alpha (U+03B1) and the Cyrillic small letter Ghe (U+0433).


Suggested change

Note that your test of uppercase characters in the `TestStartsWithUpper` method includes the Greek capital letter alpha (U+0391) and the Cyrillic capital letter EM (U+041C), and the test of lowercase characters in the `TestDoesNotStartWithUpper` method includes the Greek small letter alpha (U+03B1) and the Cyrillic small letter Ghe (U+0433).

The test of uppercase characters in the `TestStartsWithUpper` method includes the Greek capital letter alpha (U+0391) and the Cyrillic capital letter EM (U+041C). The test of lowercase characters in the `TestDoesNotStartWithUpper` method includes the Greek small letter alpha (U+03B1) and the Cyrillic small letter Ghe (U+0433).

Also I would replace the letter names with the actual characters, which can be copied from the code. Cyrillic "М" is not commonly referred to as "EM" and "г" is not referred to as "Ghe".

Would people understand what we're trying to convey in that sentence if I simply use the actual characters? I'll keep the original for now but happy to change if you think that's better.

Suggested change

Note that your test of uppercase characters in the `TestStartsWithUpper` method includes the Greek capital letter alpha (U+0391) and the Cyrillic capital letter EM (U+041C), and the test of lowercase characters in the `TestDoesNotStartWithUpper` method includes the Greek small letter alpha (U+03B1) and the Cyrillic small letter Ghe (U+0433).

The test of uppercase characters in the `TestStartsWithUpper` method includes Α and М. The test of lowercase characters in the `TestDoesNotStartWithUpper` method includes α and г.

tdykstra

LGTM, a couple of suggestions, and several of the images could use borders (https://review.docs.microsoft.com/en-us/help/contribute/contribute-how-to-create-screenshot?branch=master#gray-border-example)

docs/core/tutorials/testing-library-with-visual-studio.md

tdykstra · 2019-12-23T21:19:56Z

docs/core/tutorials/testing-library-with-visual-studio.md


   > [!NOTE]
-   > In addition to an MSTest Test project, you can also use Visual Studio to create an xUnit test project for .NET Core.
+   > In addition to an MSTest, you can also create xUnit and nUnit test projects for .NET Core in Visual Studio.


This note suggests you might want to add multiple test projects using different frameworks. It would be more helpful if it gave some clues as to why you might want to do that. That goes beyond the scope of this PR, though.

Very good point and I couldn't find this info in any of our docs here for .NET or VS. Something for us to consider later.

docs/core/tutorials/testing-library-with-visual-studio.md

tdykstra · 2019-12-23T21:33:18Z

docs/core/tutorials/testing-library-with-visual-studio.md


   [!code-csharp[Test#1](~/samples/snippets/csharp/getting_started/with_visual_studio_2017/testlib1.cs)]
+   [!code-vb[Test#1](~/samples/snippets/core/tutorials/vb-library-with-visual-studio/testlib.vb)]

   Note that your test of uppercase characters in the `TestStartsWithUpper` method includes the Greek capital letter alpha (U+0391) and the Cyrillic capital letter EM (U+041C), and the test of lowercase characters in the `TestDoesNotStartWithUpper` method includes the Greek small letter alpha (U+03B1) and the Cyrillic small letter Ghe (U+0433).


Also I would replace the letter names with the actual characters, which can be copied from the code. Cyrillic "М" is not commonly referred to as "EM" and "г" is not referred to as "Ghe".

mairaw · 2019-12-24T09:39:14Z

Didn't know about that extension to add the border. Really neat @tdykstra!

AbhitejJohn

Thanks for fixing this. Added a few comments. Also tagging @kendrahavens.

AbhitejJohn · 2019-12-26T18:58:24Z

docs/core/tutorials/testing-library-with-visual-studio.md


-   ![Visual Studio code window for the unit test project class and method - C#](./media/testing-library-with-visual-studio/unit-test-editor-window.png)
+   ```csharp


Should we call out in plain text that this would be generated for C# and the below for VB just to make things clear?

AbhitejJohn · 2019-12-26T19:00:30Z

docs/core/tutorials/testing-library-with-visual-studio.md


-1. In the **Add New Project** dialog, select the **Visual C#** node. Then select the **.NET Core** node followed by the **MSTest Test Project (.NET Core)** project template. In the **Name** text box, enter "StringLibraryTest" as the name of the project. Select **OK** to create the unit test project.
+   1. On the **Add a new project** page, enter **mstest** in the search box. Choose **C#** or **Visual Basic** from the Language list, and then choose **All platforms** from the Platform list. Choose the **MsTest Test Project (.NET Core)** template, and then choose **Next**.


We'd perhaps also want to include F# as well? In which case we'd want to change the samples below. Maybe in another PR. @kendrahavens, thoughts? I could put one out after this goes in.

Yes, we should list F#. I believe in the past, we did not have F# test templates so we didn't list it.
Since there is no VB sample, I don't think we need to add a F# sample. I don't want to overwhelm the page.

AbhitejJohn · 2019-12-26T19:02:09Z

docs/core/tutorials/testing-library-with-visual-studio.md


   [!code-csharp[Test#1](~/samples/snippets/csharp/getting_started/with_visual_studio_2017/testlib1.cs)]
+   [!code-vb[Test#1](~/samples/snippets/core/tutorials/vb-library-with-visual-studio/testlib.vb)]


Anyone know where these links point to? They appear to be broken today.

AbhitejJohn · 2019-12-26T19:04:58Z

docs/core/tutorials/testing-library-with-visual-studio.md

@@ -165,13 +143,13 @@ Your test run had no failures, but change it slightly so that one of the test me

   ![Test Explorer window with failing tests](./media/testing-library-with-visual-studio/failed-test-window.png)

-1. In the **Failed Tests** section, select the failed test, `TestDoesNotStartWith`. The **Test Explorer** window displays the message produced by the assert: "Assert.IsFalse failed. Expected for 'Error': false; actual: True". Because of the failure, all strings in the array after "Error" were not tested.
+1. Select the failed test, `TestDoesNotStartWith`. The **Test Explorer** window displays the message produced by the assert: "Assert.IsFalse failed. Expected for 'Error': false; actual: True". Because of the failure, all strings in the array after "Error" were not tested.


nit: Select the failed test, TestDoesNotStartWith, under the Failed Tests section - to make it more explicit that there is a separate grouping for failed tests.

initial commit

7fc07c5

mairaw self-assigned this Dec 21, 2019

dotnet-bot added this to the December 2019 milestone Dec 21, 2019

dotnet-bot added 📚 Area - F# Guide labels Dec 21, 2019

mairaw changed the base branch from master to vs-2019 December 21, 2019 02:50

mairaw added 2 commits December 23, 2019 11:57

finish changes

fdfb847

review headings

8334072

mairaw marked this pull request as ready for review December 23, 2019 19:59

mairaw requested a review from tdykstra as a code owner December 23, 2019 19:59

mairaw requested a review from gewarren December 23, 2019 19:59

mairaw added the rerun-labels label Dec 23, 2019

dotnet-bot removed the rerun-labels label Dec 23, 2019

mairaw added the rerun-action-opened label Dec 23, 2019

dotnet-bot removed the rerun-action-opened label Dec 23, 2019

mairaw removed 📚 Area - C# Guide labels Dec 23, 2019

mairaw mentioned this pull request Dec 23, 2019

Update .NET Core getting started docs to VS2019 #16046

Closed

17 tasks

mairaw added 2 commits December 23, 2019 12:30

resize image

390e9a0

resize two images

9dd9125

gewarren approved these changes Dec 23, 2019

View reviewed changes

tdykstra approved these changes Dec 23, 2019

View reviewed changes

mairaw added 5 commits December 24, 2019 01:12

feedback + acrolinx

65a3dc6

image borders

a1fe736

linting error

cc5803a

resize large img

a7c623b

resize images

7d82fc6

remove extra border

e6b9640

mairaw merged commit 005ea7f into dotnet:vs-2019 Dec 24, 2019

mairaw deleted the test-lib branch December 24, 2019 09:40

AbhitejJohn reviewed Dec 26, 2019

View reviewed changes

BillWagner added dotnet-core/prod and removed 📚 Area - .NET Core Guide labels Feb 10, 2021

	Note that your test of uppercase characters in the `TestStartsWithUpper` method includes the Greek capital letter alpha (U+0391) and the Cyrillic capital letter EM (U+041C), and the test of lowercase characters in the `TestDoesNotStartWithUpper` method includes the Greek small letter alpha (U+03B1) and the Cyrillic small letter Ghe (U+0433).
	The test of uppercase characters in the `TestStartsWithUpper` method includes the Greek capital letter alpha (U+0391) and the Cyrillic capital letter EM (U+041C). The test of lowercase characters in the `TestDoesNotStartWithUpper` method includes the Greek small letter alpha (U+03B1) and the Cyrillic small letter Ghe (U+0433).


		![Visual Studio code window for the unit test project class and method - C#](./media/testing-library-with-visual-studio/unit-test-editor-window.png)
		```csharp


		1. In the Add New Project dialog, select the Visual C# node. Then select the .NET Core node followed by the MSTest Test Project (.NET Core) project template. In the Name text box, enter "StringLibraryTest" as the name of the project. Select OK to create the unit test project.
		1. On the Add a new project page, enter mstest in the search box. Choose C# or Visual Basic from the Language list, and then choose All platforms from the Platform list. Choose the MsTest Test Project (.NET Core) template, and then choose Next.


		[!code-csharp[Test#1](~/samples/snippets/csharp/getting_started/with_visual_studio_2017/testlib1.cs)]
		[!code-vb[Test#1](~/samples/snippets/core/tutorials/vb-library-with-visual-studio/testlib.vb)]

Update test library for VS 2019 #16371

Update test library for VS 2019 #16371

Uh oh!

Conversation

mairaw commented Dec 21, 2019

Uh oh!

gewarren left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tdykstra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mairaw commented Dec 24, 2019

Uh oh!

AbhitejJohn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!