Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pattern matching to fix a couple small issues #1612

Merged
merged 4 commits into from
Mar 6, 2017
Merged

Update pattern matching to fix a couple small issues #1612

merged 4 commits into from
Mar 6, 2017

Conversation

BillWagner
Copy link
Member

Fixes #1479
Fixes #1585

  1. Update feature name for pattern matching (issue Pattern Matching: Check the vocabulary for "switch pattern expressions". The 'switch expression' term may be wrong in the What's new article #1479)
  2. Update description of match expressions to explain that match
    expressions in the wrong order generate a compiler error (Issue Wrong information about pattern matching switch statement #1585)
  3. Make the C# 7 samples build and run under Core

<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp1.0</TargetFramework>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we start using 1.1 based on the discussion we were having yesterday?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Good catch.

1. Update feature name for pattern matching (issue #1479)
2. Update description of match expressions to explain that match
expressions in the wrong order generate a compiler error (Issue #1585)
Directory move because the solution directory isn’t needed.
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@BillWagner BillWagner merged commit d970e86 into dotnet:master Mar 6, 2017
@BillWagner BillWagner deleted the update-new-in-7 branch March 6, 2017 20:46
BillWagner added a commit that referenced this pull request Mar 7, 2017
* Updated publishing getting started

* Converted project.json to MSBuild

* Updated csproj files to default.

* Revised VSCode topic for MSBuild-based projects

* Tutorials revised for *.csproj projects (#1488)

* Converted some project.json projects

* Replaced csproj project file.

* Updated publishing getting started

* Converted project.json to MSBuild

* Updated csproj files to default.

* Revised VSCode topic for MSBuild-based projects

* Tutorials revised for *.csproj projects (#1488)

* Remove project-json.md (#1520)

* remove doc

* changed to redirect per feedback

* updates, remove from toc

* Updated library examples for csproj.

* Revised xml doc comments topic for csproj

* Addressed comments, fixed some other issues.

* Converted samples to csproj.

* Modified build-related information.

* Addressed comments

* Changed relative URLs to absolute

* Changed links from github to docs

* Update fsharp/tutorials/getting-started-command-line (#1521)

* Updated publishing getting started

* Converted project.json to MSBuild

* Updated csproj files to default.

* Revised VSCode topic for MSBuild-based projects

* Tutorials revised for *.csproj projects (#1488)

* fsharp update to 004769

* fixing --

* undoing --

* address feedback

* addressed nits

* remove global.json add dotnet sln

* add directory output

* add dash to command line in code.

* fixing feedback

* change ms.date

* Update mstest tutorial for csproj (#1531)

* Remove project-json.md (#1520)

* remove doc

* changed to redirect per feedback

* updates, remove from toc

* Update testingng with MSTest for csproj

This topic now mirrors the unit testing with dotnet test and xunit.

* update topic for multiple platforms

This meant updating the index file, the TOC, and adding redirection due
to the file name change.

* Add the meta tag to redirect LiveFyre comments.

* Update per feedback

* Final review and proofread

* Update per feedback on PR #1538

* respond to feedback.

* fixed product name

* Revised out parameter modifier for C# 7

* Corrected bad code example links.

* Fixed one more broken link.

* Fixed alert.

* C# 7 revision of throw

* Corrected code dropout in Lambda Expressions topic.

* Fixed bad code snippet end tag

* project migration from project.json to csproj

* Revised for csproj migration

* Replaced incorrect version of csproj file

* Additional topic added

* Samples ported to MSBuild

* Fix typo

* bringing changes back

* Update pattern matching to fix a couple small issues (#1612)

* Update pattern matching to fix a couple small issues

1. Update feature name for pattern matching (issue #1479)
2. Update description of match expressions to explain that match
expressions in the wrong order generate a compiler error (Issue #1585)

* fix build issues.

Directory move because the solution directory isn’t needed.

* missed one set of build errors.

* update to the 1.1 meta package.

* temporarily disable enable_incremental_build (#1643)

* Addressed review comments

* Incorporated review comments

* removing test protocol doc (#1615)

* uses raw version of sampleQuotes.txt in link (#1652)

This makes it easier to `wget` the file.

* dotnet new updates for MSBuild/csproj (#1649)

* Update index.md

* Update index.md

* Update dependencies.md

* Update index.md

* Update dependencies.md

* Update dotnet.md

* Update index.md

* Update dependencies.md

* Update using-with-xplat-cli-msbuild-folders.md

* Update getting-started-command-line.md

* Update with-visual-studio-code.md

* Update attributes.md

* Update console-teleprompter.md

* Update console-webapiclient.md

* Update attributes.md

* Update inheritance.md

* Update string-interpolation.md

* Update working-with-linq.md

* Update working-with-linq.md

* Update dotnet-migrate.md

* Update using-with-xplat-cli-msbuild-folders.md

* Update using-with-xplat-cli-msbuild-folders.md

* Update dotnet-new.md

* Update dotnet-add-package.md

* Update dotnet-add-reference.md

* Update dotnet-build.md

* Update dotnet-add-reference.md

* Update dotnet-add-package.md

* Update dotnet-clean.md

* Update dotnet-build.md

* Update dotnet-clean.md

* Update dotnet-install-script.md

* Update dotnet-build.md

* Update dotnet-build.md

* Update dotnet-install-script.md

* Update dotnet-list-reference.md

* Update dotnet-msbuild.md

* Update dotnet-new.md

* Update dotnet-nuget-delete.md

* Update dotnet-nuget-locals.md

* Update dotnet-msbuild.md

* dotnet command updates

* Update broken xref

* Update dotnet-pack.md

* Update dotnet-publish.md

* Update using-with-xplat-cli-msbuild-folders.md

* Update with-visual-studio-code.md

* 💥 removing preview3 folder (#1650)

* test redirection with document id

removing dotnet-new from preview3

* 💥 removing preview3 folder

* removed warnings and RC4 mentions

fixing build issues

fixing more build issues

* addressed feedback

more fixes

* rebase and fixes

* fixes

* cleanup

* fix broken link

* Migration and build, publish & run fixes (#1592)

* Migration and build, publish & run fixes

This adds the migraiton document into a migration folder under the
Preview 3 folder. The migration document covers the migration from
project.json to csproj using the automated tools, points to the old DNX
migration for those people that still use that and offers some advice on
getting from pre-RC4 csproj to RC4 (and thus RTW) csproj formats.

The change also adds some content to the dotnet build, dotnet run and
dotnet publish documents to make sure that their differences are clearly
outlined.

Fixes #1512, #1509, #1515

* Fixing broken links

* Responding to PR feedback

* Responding to PR feedback.

* Resolving build breaks

* Fixing build breaks...again.

* some updates

* fixed toc entry

* addressed feedback + fixes

* more fixes

* few more fixes

* removing preview3 links

* Update getting started on macos (#1560)

* update getting started for csproj build system.

Updates all the application code,
the text in the MD file,
and the updated VS Code debugging settings.

* Update for new VS code extension behavior.

* respond to feedback.

* remove version specific notes on the SDK.

* Update the docker getting started topic. (#1503)

* Update the docker getting started topic.

* fix build errors

And update Docker build instructions

* update instructions to use dotnet add package

* Update Unit Testing with XUnit (#1487)

* Remove project-json.md (#1520)

* remove doc

* changed to redirect per feedback

* updates, remove from toc

* run dotnet migrate

* build and run tests

* move projects to the correct updated location

* Update project files and code.

* fix a file name.

* mis-typed the region name.

* proofread and update.

This is ready for review and mergning.

* update instructions to use the new CLI command.

* use updated commands

the older commands still work, but it’s better to standardize on the
new names.

* remove note about .NET Core 1.0

* update for correct xUnit branding.

* small fixes (#1655)

* Documented C# when keyword (#1647)

* documented when keyword

* Incorporated review comments

* Switch statement revised for C# 7 (#1640)

* Switch statement revised for C# 7

* Fixed bad links

* Changed 'switch expression' to 'match expression'

* Addressed review comments.

* Added code snippet tags.

* modified code

* update dotnet-install script topic (#1618)

* update dotnet-install script

* fixed word dropout

* Changes to dotnet new (#1637)

* changes to dotnet new

* removed current dir from the summary

* a few more edits

* fix two broken links. (#1657)

* fix two broken links.

* fix more bad links.

* removing RC4 from the menu

* more fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants