Skip to content

Improve acro score of new article #15256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 13, 2019
Merged

Improve acro score of new article #15256

merged 3 commits into from
Nov 13, 2019

Conversation

Thraka
Copy link
Contributor

@Thraka Thraka commented Oct 17, 2019

Summary

@MSDN-WhiteKnight Please review and make sure I didn't make anything unclear. I used our internal tool to scan for where things can be simplified (language wise) to help translation into other languages.

I cut out some clauses that don't add value, such as:

Reference assemblies are usually distributed with the Software Development Kit (SDK) of a particular platform or library, a special software component installed only on developer machines
- , a special software component installed only on developer machines

Someone reading this article is probably familiar with what an SDK is and we don't need to it explain it to them.

Copy link
Contributor

@MSDN-WhiteKnight MSDN-WhiteKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added a couple of suggestions.

Thank you for the review!

Co-Authored-By: MSDN.WhiteKnight <35516665+MSDN-WhiteKnight@users.noreply.github.com>
@Thraka Thraka requested a review from BillWagner October 21, 2019 18:43
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good @Thraka

It's ready to :shipit:

@Thraka Thraka requested a review from gewarren as a code owner November 13, 2019 19:18
@Thraka Thraka merged commit 0f94177 into master Nov 13, 2019
@Thraka Thraka deleted the adegeo-acro1 branch November 13, 2019 19:25
Youssef1313 pushed a commit to Youssef1313/docs that referenced this pull request Nov 20, 2019
* Increased acro from 80-91

* Apply suggestions from code review

Thank you for the review!

Co-Authored-By: MSDN.WhiteKnight <35516665+MSDN-WhiteKnight@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants