Skip to content

Conversation

@Thraka
Copy link
Contributor

@Thraka Thraka commented Jun 25, 2019

Summary

Rewrite templates tutorial

Fixes #12606
Fixes #11066
Fixes #5293

@mairaw
Copy link
Contributor

mairaw commented Jun 26, 2019

If you can, try running the SEO CATS scan on this branch. I think adding the additional folder would hurt SEO. You can still break the tutorial in parts without adding the additional level in the URL.

@Thraka Thraka marked this pull request as ready for review June 26, 2019 04:40
@Thraka Thraka requested a review from mairaw as a code owner June 26, 2019 04:40
@Thraka Thraka self-assigned this Jun 26, 2019
@Thraka Thraka requested review from BillWagner and rpetrusha June 26, 2019 18:05
@mairaw mairaw requested a review from KathleenDollard July 3, 2019 21:36
mairaw
mairaw previously requested changes Jul 3, 2019
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left review comments for the 1st part so far.

},
{
"source_path": "docs/core/tutorials/create-custom-template.md",
"redirect_url": "/dotnet/core/tutorials/cli-templates-create-item-template"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion for file name so you don't have template in there twice:

Suggested change
"redirect_url": "/dotnet/core/tutorials/cli-templates-create-item-template"
"redirect_url": "/dotnet/core/tutorials/create-item-template-cli"

Copy link
Contributor Author

@Thraka Thraka Jul 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to try and group them together somehow. Since a new folder is out of the question, do you have a suggestion on a file name format that keeps the related files similar to find in a directory listing?

Thraka and others added 4 commits July 8, 2019 09:07
@Thraka
Copy link
Contributor Author

Thraka commented Jul 11, 2019

@BillWagner How about you? 😄 Quick scan?

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you’ve addressed all @mairaw’s comments. You can :shipit: when ready.

@BillWagner BillWagner dismissed mairaw’s stale review July 12, 2019 00:09

All the requested changes have been addressed.

@Thraka Thraka merged commit e60919b into master Jul 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the adegeo-12606 branch July 12, 2019 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants