-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Update cli templates to tutorial series #13024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
If you can, try running the SEO CATS scan on this branch. I think adding the additional folder would hurt SEO. You can still break the tutorial in parts without adding the additional level in the URL. |
mairaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left review comments for the 1st part so far.
| }, | ||
| { | ||
| "source_path": "docs/core/tutorials/create-custom-template.md", | ||
| "redirect_url": "/dotnet/core/tutorials/cli-templates-create-item-template" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion for file name so you don't have template in there twice:
| "redirect_url": "/dotnet/core/tutorials/cli-templates-create-item-template" | |
| "redirect_url": "/dotnet/core/tutorials/create-item-template-cli" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to try and group them together somehow. Since a new folder is out of the question, do you have a suggestion on a file name format that keeps the related files similar to find in a directory listing?
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
|
@BillWagner How about you? 😄 Quick scan? |
BillWagner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you’ve addressed all @mairaw’s comments. You can
when ready.
All the requested changes have been addressed.
Summary
Rewrite templates tutorial
Fixes #12606
Fixes #11066
Fixes #5293