Update portability-analyzer.md #12986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update windows-compat-pack link to relative link Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
rewording Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Add space line Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Rewording Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Rewording Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Change to relative link Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Remove extra space Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
marklio
reviewed
Jun 25, 2019
marklio
reviewed
Jun 25, 2019
marklio
reviewed
Jun 25, 2019
marklio
reviewed
Jun 25, 2019
marklio
reviewed
Jun 25, 2019
marklio
approved these changes
Jun 25, 2019
marklio
left a comment
marklio
left a comment
There was a problem hiding this comment.
Made a few suggestions. This seems strictly better.
Change to lower case Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Make sense Co-Authored-By: Mark Miller <mark@marklio.com>
Thanks for the rewording Co-Authored-By: Mark Miller <mark@marklio.com>
Thanks for the rewording Co-Authored-By: Mark Miller <mark@marklio.com>
Suggestion make sense Co-Authored-By: Mark Miller <mark@marklio.com>
and a few minor fix-up
use https://aka.ms/apiportdownload download link for ApiPort console app.
The previous portability image was out of date.
to give more concrete guidance about when to use which target
Contributor
Author
twsouthwick
reviewed
Jul 3, 2019
To clarify that nothing wrong about having a list of missing assembly reported, but need to address them appropriately.
Contributor
Author
|
@mairaw Thanks for all the feedbacks. Have the updates addressed all your concerns? |
Thraka
suggested changes
Jul 9, 2019
Contributor
|
@Lxiamail Hi! Maira is on vacation. I left some feedback about issues I noticed. |
rewording per feedback Co-Authored-By: Andy De George <2672110+Thraka@users.noreply.github.com>
reword per feedback Co-Authored-By: Andy De George <2672110+Thraka@users.noreply.github.com>
reword Co-Authored-By: Andy De George <2672110+Thraka@users.noreply.github.com>
reword Co-Authored-By: Andy De George <2672110+Thraka@users.noreply.github.com>
Co-Authored-By: Andy De George <2672110+Thraka@users.noreply.github.com>
Thraka
reviewed
Jul 10, 2019
Contributor
Author
|
@Thraka Do you have any other concern? |
Contributor
|
@Lxiamail the screenshots needed a gray border so the white areas don't blend in. I added that to each screenshot and committed that for you 😄 I'm going to merge it. Awesome job! |
Thraka
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated .NET portability analyzer doc to clarify some concepts, add more explanation (especially for how to interpret the report), and fixed some links.
Fixes #12985