Skip to content

Update active pattern syntax representation #12628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2019
Merged

Update active pattern syntax representation #12628

merged 1 commit into from
Jun 4, 2019

Conversation

@cartermp
Copy link
Contributor

@cartermp cartermp commented Jun 2, 2019

Fixes #12315

rpetrusha
rpetrusha approved these changes Jun 2, 2019
View reviewed changes
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can merge when you're ready, @cartermp.

@rpetrusha rpetrusha added this to the June 2019 milestone Jun 2, 2019
@mairaw mairaw removed this from the June 2019 milestone Jun 4, 2019
@cartermp cartermp merged commit d45b74c into master Jun 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the cartermp-patch-2 branch June 4, 2019 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cartermp cartermp

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Misleading syntax description

4 participants

@cartermp @rpetrusha @mairaw