Skip to content

Change chapters ordering #10643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 23, 2019
Merged

Change chapters ordering #10643

merged 4 commits into from
Feb 23, 2019

Conversation

Potapy4
Copy link
Contributor

@Potapy4 Potapy4 commented Feb 22, 2019

Fixes #10629

mairaw
mairaw requested changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Potapy4 for jumping on the issue. Left a comment about the formatting and also we should change the TOC file to have the same order:
https://github.com/dotnet/docs/blob/master/docs/framework/wpf/advanced/toc.md
image

@mairaw mairaw added this to the February 2019 milestone Feb 22, 2019
nxtn
nxtn suggested changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@nxtn nxtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can be done by scripts. Would you like another issue to track it?

@nxtn
Copy link
Contributor

nxtn commented Feb 22, 2019

I prefer - for unordered lists... :)

docs/styleguide/template.md

Lines 203 to 209 in 481c63c

### Unordered Lists
- This
- is
- a
- bulleted
- list

mairaw
mairaw approved these changes Feb 23, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Potapy4 for making the additional changes! Looks great!

@mairaw mairaw merged commit b0eb506 into dotnet:master Feb 23, 2019
@Potapy4 Potapy4 deleted the patch-3 branch February 23, 2019 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nxtn nxtn nxtn requested changes

@mairaw mairaw mairaw approved these changes

Assignees

@Potapy4 Potapy4

Labels
None yet
Projects
None yet
Milestone
February 2019
Development

Successfully merging this pull request may close these issues.
3 participants
@Potapy4 @nxtn @mairaw