-
Notifications
You must be signed in to change notification settings - Fork 6k
fixed absolute and msdn links #1001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Open Publishing Build Service: The pull request content has been published and here are some sample preview links:
|
@@ -61,11 +61,11 @@ Some namespaces are so frequently used in F# code that they are opened implicitl | |||
|`Microsoft.FSharp.Text`|Contains functions for formatted IO, such as the `printf` function.| | |||
|
|||
## AutoOpen Attribute | |||
You can apply the `AutoOpen` attribute to an assembly if you want to automatically open a namespace or module when the assembly is referenced. You can also apply the `AutoOpen` attribute to a module to automatically open that module when the parent module or namespace is opened. For more information, see [Core.AutoOpenAttribute Class](https://stage.docs.microsoft.com/en-us/dotnet/articles/fsharp/language-reference/core.autoopenattribute-class). | |||
You can apply the `AutoOpen` attribute to an assembly if you want to automatically open a namespace or module when the assembly is referenced. You can also apply the `AutoOpen` attribute to a module to automatically open that module when the parent module or namespace is opened. For more information, see [Core.AutoOpenAttribute Class](https://msdn.microsoft.com/visualfsharpdocs/conceptual/core.autoopenattribute-class-%5bfsharp%5d). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why dod you move from a docs.microsoft.com article to an MSDN article?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think stage.docs.microsoft.com should appear in published docs (the old link certainly doesn't work for me).
I'm assuming it's related to this note on another F# article:
The API reference links in this article will take you to MSDN. The docs.microsoft.com API reference is not complete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that's why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this topic hasn't been moved to docs yet and I talked to @cartermp offline to confirm the change before I submitted this PR.
Looks great. I noticed two small typos, and had a couple questions. Once you fix the typos, |
LGTM! |
@BillWagner I saw the comment about the missing space. Was there another typo (you mention two in your comment)? The change to MSDN links was on purpose. |
Open Publishing Build Service: The pull request content has been published and here are some sample preview links:
|
@mairaw It was just the one. Off-by-one error on my part. |
No problem @BillWagner. Just wanted to make sure I didn't miss anything. I'll fix the conflicts and merge this. Thanks! |
Open Publishing Build Service: The pull request content has been published and here are some sample preview links:
|
@@ -79,7 +79,7 @@ type TerraService = WsdlService<" HYPERLINK "http://terraserver-usa.com/TerraSer | |||
``` | |||
|
|||
A red squiggle appears under this line of code if the service URI is misspelled or if the service itself is down or isn’t performing. If you point to the code, an error message describes the problem. You can find the same information in the **Error List** window or in the **Output Window** after you build. | |||
<br /> There are two ways to specify configuration settings for a WSDL connection, by using the app.config file for the project, or by using the static type parameters in the type provider declaration. You can use svcutil.exe to generate appropriate configuration file elements. For more information about using svcutil.exe to generate configuration information for a web service, see [ServiceModel Metadata Utility Tool (Svcutil.exe)](https://msdn.microsoft.com/library/aa347733.aspx).For a full description of the static type parameters for the WSDL type provider, see [WsdlService Type Provider](https://msdn.microsoft.com/en-us/visualfsharpdocs/conceptual/wsdlservice-type-provider-%5bfsharp%5d). | |||
<br /> There are two ways to specify configuration settings for a WSDL connection, by using the app.config file for the project, or by using the static type parameters in the type provider declaration. You can use svcutil.exe to generate appropriate configuration file elements. For more information about using svcutil.exe to generate configuration information for a web service, see [ServiceModel Metadata Utility Tool (Svcutil.exe)](https://msdn.microsoft.com/library/aa347733.aspx). For a full description of the static type parameters for the WSDL type provider, see [WsdlService Type Provider](https://msdn.microsoft.com/visualfsharpdocs/conceptual/wsdlservice-type-provider-%5bfsharp%5d). | |||
<br /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cartermp I've noticed that we use some HTML elements throughout the F# content. Some are needed like the one for the pipes inside tables but in some cases they seem unnecessary like the
tags in this topic. Should we open a low-pri issue to clean HTML tags throughout the content?
Open Publishing Build Service: The pull request content has been published and here are some sample preview links:
|
Fixes #756
/cc @BillWagner @cartermp
Removed en-us and version from msdn links so that localized versions in the future will take the user to the language stored in their browser cache. Removing the version to always go to the tip.
Made other small fixes on the affected topics.
I haven't changed the API links that will be handled separately and are tracked by this issue: #787