Clarify async scenarios and deadlocks #2112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KlausLoeffelmann
requested changes
Aug 19, 2025
There was a problem hiding this comment.
Let's talk about a few aspects here.
We should also address .ConfigureAwait(true/false), and point out, how it can help in simplifying certain type of marshalling work, but can also impose deadlocks when applied poorly.
For the ValueTask issue in VB, I think I have a workaround, which we should provide in the docs.
dotnet-desktop-guide/winforms/controls/snippets/how-to-make-thread-safe-calls/cs/Form1.cs
Outdated
Show resolved
Hide resolved
dotnet-desktop-guide/winforms/controls/snippets/how-to-make-thread-safe-calls/cs/Form1.cs
Outdated
Show resolved
Hide resolved
dotnet-desktop-guide/winforms/controls/how-to-make-thread-safe-calls.md
Outdated
Show resolved
Hide resolved
dotnet-desktop-guide/winforms/controls/how-to-make-thread-safe-calls.md
Outdated
Show resolved
Hide resolved
dotnet-desktop-guide/winforms/controls/how-to-make-thread-safe-calls.md
Outdated
Show resolved
Hide resolved
...op-guide/winforms/controls/snippets/how-to-make-thread-safe-calls/cs/FormBackgroundWorker.cs
Outdated
Show resolved
Hide resolved
dotnet-desktop-guide/winforms/controls/snippets/how-to-make-thread-safe-calls/cs/FormThread.cs
Outdated
Show resolved
Hide resolved
...top-guide/winforms/controls/snippets/how-to-make-thread-safe-calls/cs/InvokeAsyncExamples.cs
Outdated
Show resolved
Hide resolved
...top-guide/winforms/controls/snippets/how-to-make-thread-safe-calls/cs/InvokeAsyncExamples.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Klaus Löffelmann <9663150+KlausLoeffelmann@users.noreply.github.com>
Co-authored-by: Klaus Löffelmann <9663150+KlausLoeffelmann@users.noreply.github.com>
Co-authored-by: Klaus Löffelmann <9663150+KlausLoeffelmann@users.noreply.github.com>
Co-authored-by: Klaus Löffelmann <9663150+KlausLoeffelmann@users.noreply.github.com>
|
@KlausLoeffelmann I addressed your feedback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A long time coming. Updates a few places with information about deadlocks and demonstrates code. Also adds reference to the new InvokeAsync methods in .NET 9.
Fixes #1406
Internal previews