-
Notifications
You must be signed in to change notification settings - Fork 153
Use Orleans with .NET Aspire #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This will need a TOC entry, and maybe even a hub page listing. Are the TODO's here indicating that this is a draft, or is it ready for review? |
The TODOs are future improvements - they're not needed for the first version |
Probably doesn't belong under fundamentals. Maybe we have another top level section for framework integrations. |
@IEvangelist what are your thoughts on what the new section should be called? "Frameworks"? Perhaps SignalR should also be in the same section. Currently, it has its own section, Real-time communication. |
Good to know, it's probably worth placing those inside the article as well as a comment so that we have it for later - we could even create an issue to track those improvements too. Use HTML comments in the MD: <!--
Ideas for future improvement:
- Add section showing how to add multiple storage providers
- Add deployment section? Unsure it's needed
- Add section on extensibility: how to ensure that your Orleans providers work with .NET Aspire. The rough answer is that you add an assembly-wide attribute and a config class to your provider library which understands how to read config generated by .NET Aspire and configure your provider with it.
--> |
I like that, "Frameworks" as a new top-level node with those seems to fit nicely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start, several nits - and a few other suggestions!
✅ Merge `main` into `live`
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Since the SignalR page is specifically about Azure SignalR, maybe I should leave it where it is |
Ok, I think this is ready, @IEvangelist. Please take another look when you're available |
Thanks for getting this over the line, @IEvangelist! |
Summary
First pass at Orleans + Aspire doc
Fixes #702
Fixes #808
Ideas for future improvement:
Internal previews