Add command to wait for EOL annotation ingestion#1367
Merged
mthalman merged 5 commits intodotnet:mainfrom Jul 24, 2024
Merged
Conversation
Factors out the --timeout and --requery-delay options so they can be reused by multiple commands.
ghost
added
19 tasks
lbussell
reviewed
Jul 23, 2024
Member
lbussell
left a comment
lbussell
left a comment
There was a problem hiding this comment.
Not totally done reading through this yet.
src/Microsoft.DotNet.ImageBuilder/src/Commands/WaitForMcrImageIngestionOptions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.ImageBuilder/src/Commands/WaitForMarAnnotationIngestionOptions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.ImageBuilder/src/MarImageIngestionReporter.cs
Outdated
Show resolved
Hide resolved
lbussell
approved these changes
Jul 24, 2024
lbussell
approved these changes
Jul 24, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will enable the pipeline to validate that the EOL annotations that have been pushed are successfully ingested by MAR.
This refactors the existing image ingestion command so that it can reuse the logic defined there. See separate commits for refactoring.
Contributes to #1201