Add a new command for annotating image digests for EOL#1334
Merged
NikolaMilosavljevic merged 15 commits intodotnet:mainfrom Jun 19, 2024
Merged
Add a new command for annotating image digests for EOL#1334NikolaMilosavljevic merged 15 commits intodotnet:mainfrom
NikolaMilosavljevic merged 15 commits intodotnet:mainfrom
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Member
Author
|
Hmm, some test failures on Linux. This worked fine on Windows. Working on a fix. |
mthalman
reviewed
Jun 14, 2024
Comment on lines
33
to
34
| CreateOption<bool>("no-check", nameof(AnnotateEolDigestsOptions.NoCheck), | ||
| "Annotate always, without checking if digest is already annotated for EOL"), |
Member
There was a problem hiding this comment.
Consider using force as the name of the option instead. It's more commonly used.
Member
Author
There was a problem hiding this comment.
force was the option I also considered. Yeah, it makes sense to use it - will fix.
src/Microsoft.DotNet.ImageBuilder/src/Commands/AnnotateEolDigestsOptions.cs
Outdated
Show resolved
Hide resolved
Comment on lines
21
to
23
| public AnnotateEolDigestsOptions() : base() | ||
| { | ||
| } |
Member
Author
There was a problem hiding this comment.
Right, forgot to remove - thanks.
src/Microsoft.DotNet.ImageBuilder/src/Models/Annotations/EolDigestData.cs
Show resolved
Hide resolved
src/Microsoft.DotNet.ImageBuilder/src/Commands/AnnotateEolDigestsCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.ImageBuilder/src/Commands/AnnotateEolDigestsCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.ImageBuilder/tests/AnnotateEolDigestsCommandTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.ImageBuilder/tests/AnnotateEolDigestsCommandTests.cs
Outdated
Show resolved
Hide resolved
…stsOptions.cs Co-authored-by: Matt Thalman <mthalman@microsoft.com>
Co-authored-by: Matt Thalman <mthalman@microsoft.com>
…stsCommand.cs Co-authored-by: Matt Thalman <mthalman@microsoft.com>
mthalman
reviewed
Jun 17, 2024
mthalman
reviewed
Jun 17, 2024
src/Microsoft.DotNet.ImageBuilder/src/Commands/AnnotateEolDigestsOptions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.ImageBuilder/src/Commands/AnnotateEolDigestsOptions.cs
Outdated
Show resolved
Hide resolved
mthalman
reviewed
Jun 18, 2024
mthalman
reviewed
Jun 19, 2024
src/Microsoft.DotNet.ImageBuilder/src/Models/Annotations/EolAnnotationsData.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.ImageBuilder/src/Models/Annotations/OciManifest.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.ImageBuilder/src/Models/Annotations/OciManifest.cs
Outdated
Show resolved
Hide resolved
mthalman
approved these changes
Jun 19, 2024
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to: #1201
The work is being split into smaller PRs to aid in review process.
Some notes:
oras discovercommand and its stdout. This will likely be updated once Oras completed the work on managed library.oras logincommand was not needed, as we already dodocker loginJSON file format (with sample dates):
EOL data can be specified as a global value (optional) for all digests in the file. Each digest can have its own specific EOL date, which overrides the global value (if set).