Skip to content

fix: Toc warnings when toc item with TopicUid but name is not specified #9665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yufeih merged 2 commits into from
Feb 10, 2024
Merged

fix: Toc warnings when toc item with TopicUid but name is not specified #9665

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38d54e4
fix: warnings for tocitem when topicuid specified but name is not sp…
filzrev Jan 30, 2024
0648e4b
Merge branch 'main' into fix-toc-warnings-for-topicuid
filzrev Feb 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Docfx.Build/ManifestProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,8 +208,13 @@ void UpdateTocNameCore(List<TocItemViewModel> items)
{
if (string.IsNullOrEmpty(node.Name))
{
// Try to get title from href
if (node.Href is not null && titles.TryGetValue(UriUtility.GetPath(node.Href), out var title))
node.Name = title;
// If topicUid exists. Name is resolved by TocDocumentProcessor
else if (node.TopicUid != null)
{
}
else
Logger.LogWarning(
$"TOC item ({node}) with empty name found. Missing a name?",
Expand Down