Skip to content

Conversation

@filzrev
Copy link
Contributor

@filzrev filzrev commented Oct 27, 2023

What's changed in this PR
Change visibility of project-scoped helper class from public to internal.

Background
This PR intended to avoid some classes that have generic name displayed as code completion targets
when using Docfx.App package.

@filzrev filzrev force-pushed the chore-change-visibility-to-internal branch from f66fba6 to 2b1a414 Compare October 27, 2023 13:25
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/Docfx.HtmlToPdf/Guard.cs 0.00% <ø> (ø)
src/Docfx.MarkdigEngine.Extensions/Constants.cs 100.00% <ø> (ø)

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yufeih yufeih merged commit cfb4946 into dotnet:main Oct 27, 2023
@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Oct 27, 2023
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
…tnet#9347)

chore: change project scoped utility class visibility to internal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants