Skip to content

Conversation

@yufeih
Copy link
Contributor

@yufeih yufeih commented Oct 20, 2023

fixes #9088

@yufeih yufeih added the performance Makes the pull request appear in "Performance" section of the next release note label Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/Docfx.App/RunBuild.cs 54.54% <ø> (-3.79%) ⬇️
src/Docfx.Build.SchemaDriven/OverwriteApplier.cs 89.74% <100.00%> (ø)
src/Docfx.Common/Git/GitRepoInfo.cs 100.00% <ø> (+18.18%) ⬆️
src/Docfx.Common/Git/GitDetail.cs 75.00% <75.00%> (+41.66%) ⬆️
src/Docfx.Dotnet/Parsers/XmlComment.cs 78.82% <0.00%> (ø)
src/Docfx.Common/Git/GitUtility.cs 79.12% <78.00%> (+0.93%) ⬆️

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@yufeih yufeih closed this Oct 20, 2023
@yufeih yufeih reopened this Oct 20, 2023
@KalleOlaviNiemitalo
Copy link

I assume this causes GitReader.dll to be distributed within the docfx .NET tool package. That file seems to be licensed under the Apache-2.0 license; will the distribution satisfy clause 4. (a) of the license terms? AFAICT, the docfx 2.71.1 package does not contain the Apache-2.0 license terms, although some files in it reference the license.

@yufeih yufeih closed this Oct 20, 2023
@yufeih yufeih reopened this Oct 20, 2023
@yufeih
Copy link
Contributor Author

yufeih commented Oct 20, 2023

I assume this causes GitReader.dll to be distributed within the docfx .NET tool package. That file seems to be licensed under the Apache-2.0 license; will the distribution satisfy clause 4. (a) of the license terms? AFAICT, the docfx 2.71.1 package does not contain the Apache-2.0 license terms, although some files in it reference the license.

True. Thanks for the reminder. You are awesome!

@yufeih yufeih closed this Oct 20, 2023
@yufeih yufeih reopened this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Makes the pull request appear in "Performance" section of the next release note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Using git library to extract git related information

4 participants