Skip to content

feat: add --memberLayout argument to metadata command #9244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yufeih merged 1 commit into from
Sep 25, 2023
Merged

feat: add --memberLayout argument to metadata command #9244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,9 @@ jobs:
- run: dotnet run -c Release --no-build -f net8.0 --project src/docfx -- docs/docfx.json

- run: dotnet run -c Release --no-build -f net8.0 --project src/docfx -- metadata samples/seed/docfx.json
- run: dotnet run -c Release --no-build -f net8.0 --project src/docfx -- metadata samples/seed/docfx.json --outputFormat markdown --output samples/seed/md
- run: dotnet run -c Release --no-build -f net8.0 --project src/docfx -- metadata samples/seed/docfx.json --outputFormat markdown --output samples/seed/md2 --namespaceLayout nested --memberLayout separatePages
- run: dotnet run -c Release --no-build -f net8.0 --project src/docfx -- build samples/seed/docfx.json --output docs/_site/seed
- run: dotnet run -c Release --no-build -f net8.0 --project src/docfx -- metadata samples/seed/docfx.json --outputFormat markdown --output docs/_site/seed/md

- uses: actions/upload-artifact@v3
if: matrix.os == 'ubuntu-latest'
Expand Down
1 change: 1 addition & 0 deletions src/docfx/Models/MetadataCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ private static void MergeOptionsToConfig(MetadataCommandOptions options, Metadat
item.DisableGitFeatures |= options.DisableGitFeatures;
item.DisableDefaultFilter |= options.DisableDefaultFilter;
item.NamespaceLayout = options.NamespaceLayout ?? item.NamespaceLayout;
item.MemberLayout = options.MemberLayout ?? item.MemberLayout;
item.OutputFormat = options.OutputFormat ?? item.OutputFormat;

if (!string.IsNullOrEmpty(options.FilterConfigFile))
Expand Down
4 changes: 4 additions & 0 deletions src/docfx/Models/MetadataCommandOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,8 @@ internal class MetadataCommandOptions : LogOptions
[Description("Determines the namespace layout in table of contents.")]
[CommandOption("--namespaceLayout")]
public NamespaceLayout? NamespaceLayout { get; set; }

[Description("Determines the member page layout.")]
[CommandOption("--memberLayout")]
public MemberLayout? MemberLayout { get; set; }
}