Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove tab group hash function #8942

Merged
merged 2 commits into from
Jul 7, 2023
Merged

fix: remove tab group hash function #8942

merged 2 commits into from
Jul 7, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Jul 7, 2023

Backport #7198

@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Jul 7, 2023
@yufeih yufeih closed this Jul 7, 2023
@yufeih yufeih reopened this Jul 7, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (71e1479) 76.90% compared to head (ce5f834) 76.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8942      +/-   ##
==========================================
- Coverage   76.90%   76.89%   -0.02%     
==========================================
  Files         605      605              
  Lines       25088    25074      -14     
==========================================
- Hits        19295    19280      -15     
- Misses       5793     5794       +1     
Impacted Files Coverage Δ
...Engine.Extensions/Aggregator/TabGroupAggregator.cs 100.00% <ø> (ø)
...e.Extensions/TabGroup/HtmlTabGroupBlockRenderer.cs 100.00% <100.00%> (ø)
...MarkdigEngine.Extensions/TabGroup/TabGroupBlock.cs 100.00% <100.00%> (ø)
...igEngine.Extensions/TabGroup/TabGroupIdRewriter.cs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih yufeih merged commit 9134d6c into main Jul 7, 2023
@yufeih yufeih deleted the tab-no-hash branch July 7, 2023 04:39
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant