Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply build-in code formatters #8912

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Jun 30, 2023

This PR apply following build-in code formatters. (styles are defined on .editorconfig settings)

  1. Fix whitespaces with dotnet format whitespace command (f1dfc9d)
  2. Fix styles with dotnet format style command (3076cc1)

Purpose of this PR
Avoid formatting related diff occurred when creating PR.

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage: 77.77% and project coverage change: +0.01 🎉

Comparison is base (c0b8541) 77.04% compared to head (3076cc1) 77.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8912      +/-   ##
==========================================
+ Coverage   77.04%   77.05%   +0.01%     
==========================================
  Files         605      605              
  Lines       25040    25038       -2     
==========================================
+ Hits        19293    19294       +1     
+ Misses       5747     5744       -3     
Impacted Files Coverage Δ
...crosoft.DocAsCode.App/Config/ContentPairingInfo.cs 0.00% <ø> (ø)
...soft.DocAsCode.App/Config/FileMetadataPairsItem.cs 100.00% <ø> (ø)
...Code.App/Config/ListWithStringFallbackConverter.cs 40.00% <0.00%> (ø)
...soft.DocAsCode.App/Config/WkhtmltopdfJsonConfig.cs 0.00% <ø> (ø)
src/Microsoft.DocAsCode.App/Docset.cs 100.00% <ø> (ø)
.../Microsoft.DocAsCode.App/Helpers/MetadataMerger.cs 0.00% <ø> (ø)
src/Microsoft.DocAsCode.App/RunPdf.cs 0.00% <0.00%> (ø)
...buteHandlers/Handlers/BaseModelAttributeHandler.cs 89.65% <ø> (ø)
...e.Build.Common/Reference/ApplyOverwriteDocument.cs 94.04% <ø> (ø)
...e.Build.Common/Reference/OverwriteDocumentModel.cs 100.00% <ø> (ø)
... and 159 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Did you manually run these commands before checkin?

@yufeih yufeih merged commit 971df08 into dotnet:main Jun 30, 2023
@filzrev
Copy link
Contributor Author

filzrev commented Jun 30, 2023

Looks great!

Did you manually run these commands before checkin?

Yes. I executed commands manually.
It would be appreciated if it is automatically correct & enforce the formatting on the CI side.

@filzrev filzrev deleted the fix-code-formatting branch June 30, 2023 12:08
@yufeih yufeih added the engineering Makes the pull request to appear in the "Engineering" section of the next release note label Jul 24, 2023
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Makes the pull request to appear in the "Engineering" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants