-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled ESRPCodeSign for docfx v2 - dev #5832
Merged
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9ac334b
Enable code sign for docfxv2 - dev
sharanya-rao 8a4de0f
Updated matched paths with include filters instead of exclude paths.
sharanya-rao 5b7e998
minor fix
sharanya-rao 419318b
fixed build error
sharanya-rao 2f65996
Included pack step
sharanya-rao eb80e9a
Resolved review comments.
sharanya-rao b105b6e
Fixed batchsign policy file.
sharanya-rao 942b9d9
Fixed build/pack/codesign
sharanya-rao 350a624
Fixed indentation; Moved pack after e2etest
sharanya-rao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,125 @@ | ||
| { | ||
| "Version": "1.0.0", | ||
| "UseMinimatch": true, | ||
| "SignBatches": [ | ||
| { | ||
| "MatchedPath": [ | ||
| "Microsoft.DocAsCode*.dll", | ||
| "*.exe" | ||
| ], | ||
| "SigningInfo": { | ||
| "Operations": [ | ||
| { | ||
| "KeyCode": "CP-230012", | ||
| "OperationSetCode": "SigntoolSign", | ||
| "parameters": [ | ||
| { | ||
| "parameterName": "OpusName", | ||
| "parameterValue": "Microsoft" | ||
| }, | ||
| { | ||
| "parameterName": "OpusInfo", | ||
| "parameterValue": "http://www.microsoft.com" | ||
| }, | ||
| { | ||
| "parameterName": "PageHash", | ||
| "parameterValue": "/NPH" | ||
| }, | ||
| { | ||
| "parameterName": "TimeStamp", | ||
| "parameterValue": "/tr \"http://rfc3161.gtm.corp.microsoft.com/TSS/HttpTspServer\" /td sha256" | ||
| }, | ||
| { | ||
| "parameterName": "FileDigest", | ||
| "parameterValue": "/fd \"SHA256\"" | ||
| } | ||
| ], | ||
| "ToolName": "sign", | ||
| "ToolVersion": "1.0" | ||
| }, | ||
| { | ||
| "KeyCode": "CP-230012", | ||
| "OperationSetCode": "SigntoolVerify", | ||
| "Parameters": [ | ||
| { | ||
| "parameterName": "VerifyAll", | ||
| "parameterValue": "/all" | ||
| } | ||
| ], | ||
| "ToolName": "sign", | ||
| "ToolVersion": "1.0" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "MatchedPath": [ | ||
| "DotLiquid.resources.dll", | ||
| "AutoMapper.dll", | ||
| "CommandLine.dll", | ||
| "DotLiquid.dll", | ||
| "Dotnet.ProjInfo.dll", | ||
| "Dotnet.ProjInfo.Helpers.dll", | ||
| "FSharp.Compiler.*.dll", | ||
| "HtmlAgilityPack.dll", | ||
| "itextsharp.dll", | ||
| "Jint.dll", | ||
| "Markdig.dll", | ||
| "Newtonsoft.Json.dll", | ||
| "Newtonsoft.Json.Schema.dll", | ||
| "Nustache.Core.dll", | ||
| "Owin.dll", | ||
| "SQLitePCLRaw.core.dll", | ||
| "YamlDotNet.dll" | ||
| ], | ||
| "SigningInfo": { | ||
| "Operations": [ | ||
| { | ||
| "KeyCode": "CP-231522", | ||
| "OperationSetCode": "SigntoolSign", | ||
| "parameters": [ | ||
| { | ||
| "parameterName": "OpusName", | ||
| "parameterValue": "Microsoft" | ||
| }, | ||
| { | ||
| "parameterName": "OpusInfo", | ||
| "parameterValue": "http://www.microsoft.com" | ||
| }, | ||
| { | ||
| "parameterName": "Append", | ||
sharanya-rao marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "parameterValue": "/as" | ||
| }, | ||
| { | ||
| "parameterName": "PageHash", | ||
| "parameterValue": "/NPH" | ||
| }, | ||
| { | ||
| "parameterName": "TimeStamp", | ||
| "parameterValue": "/tr \"http://rfc3161.gtm.corp.microsoft.com/TSS/HttpTspServer\" /td sha256" | ||
| }, | ||
| { | ||
| "parameterName": "FileDigest", | ||
| "parameterValue": "/fd \"SHA256\"" | ||
| } | ||
| ], | ||
| "ToolName": "sign", | ||
| "ToolVersion": "1.0" | ||
| }, | ||
| { | ||
| "KeyCode": "CP-231522", | ||
| "OperationSetCode": "SigntoolVerify", | ||
| "Parameters": [ | ||
| { | ||
| "parameterName": "VerifyAll", | ||
| "parameterValue": "/all" | ||
| } | ||
| ], | ||
| "ToolName": "sign", | ||
| "ToolVersion": "1.0" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| ] | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| function GetOperatingSystemName() | ||
| { | ||
| if ([environment]::OSVersion.Platform -eq "Win32NT") { | ||
| return "Windows" | ||
| } | ||
| else { | ||
| return "Linux" | ||
| } | ||
| } | ||
|
|
||
| function GetNuGetCommand([string]$os) | ||
| { | ||
| if ($os -eq "Windows") { | ||
| return "$env:LOCALAPPDATA/Nuget/Nuget.exe" | ||
| } | ||
| else { | ||
| return "nuget" | ||
| } | ||
| } | ||
|
|
||
| function ProcessLastExitCode { | ||
| param($exitCode, $msg) | ||
| if ($exitCode -eq 0) { | ||
| Write-Host "Success: $msg | ||
| " -ForegroundColor Green | ||
| } | ||
| else { | ||
| Write-Host "Error $($exitCode): $msg | ||
| " -ForegroundColor Red | ||
| Pop-Location | ||
| Exit 1 | ||
| } | ||
| } | ||
|
|
||
| function ValidateCommand { | ||
| param($command) | ||
| return (Get-Command $command -ErrorAction SilentlyContinue) -ne $null | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you used
!Microsoft*.dllin this PR earlier. Can it work?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't seem to work, therefore explicitly listed them.