Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto pack template in build.cmd #379

Merged
merged 5 commits into from
Jun 14, 2016
Merged

Auto pack template in build.cmd #379

merged 5 commits into from
Jun 14, 2016

Conversation

qinezh
Copy link
Contributor

@qinezh qinezh commented Jun 13, 2016

ECHO ERROR: UpdateTemplate.cmd requires node installed globally.
GOTO :Exit
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also check gulp?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to check gulp since the step npm install will install it and other dependency

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I meet the error 'gulp' is not recognized as an internal or external command, operable program or batch file.... Seems need to install gulp globally?

Copy link
Contributor Author

@qinezh qinezh Jun 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I should add a step to install gulp globally

PUSHD %TemplateHome%
CALL npm install
CALL gulp
POPD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed one popd in the end

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually only one pair of pushd and popd is needed at beginning and end of the script.


In reply to: 66747755 [](ancestors = 66747755)

WHERE node >NUL
IF NOT '%ERRORLEVEL%'=='0' (
ECHO ERROR: UpdateTemplate.cmd requires node installed globally.
GOTO :Exit
Copy link
Contributor

@hellosnow hellosnow Jun 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add definition for Exit? #Closed

@hellosnow
Copy link
Contributor

:shipit:

@superyyrrzz
Copy link
Contributor

👍

@qinezh qinezh merged commit c0d51d4 into dotnet:dev Jun 14, 2016
@qinezh qinezh deleted the autopack branch June 14, 2016 05:55
@superyyrrzz
Copy link
Contributor

@DuncanmaMSFT We've removed the ZIPs from our repo, as build.cmd will generate them automatically. So the ZIPs are no longer required in commits.

superyyrrzz pushed a commit that referenced this pull request Jun 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants