-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto pack template in build.cmd #379
Conversation
ECHO ERROR: UpdateTemplate.cmd requires node installed globally. | ||
GOTO :Exit | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also check gulp?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to check gulp since the step npm install
will install it and other dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I meet the error 'gulp' is not recognized as an internal or external command, operable program or batch file.
... Seems need to install gulp globally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I should add a step to install gulp globally
PUSHD %TemplateHome% | ||
CALL npm install | ||
CALL gulp | ||
POPD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missed one popd in the end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually only one pair of pushd and popd is needed at beginning and end of the script.
In reply to: 66747755 [](ancestors = 66747755)
WHERE node >NUL | ||
IF NOT '%ERRORLEVEL%'=='0' ( | ||
ECHO ERROR: UpdateTemplate.cmd requires node installed globally. | ||
GOTO :Exit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add definition for Exit? #Closed
👍 |
@DuncanmaMSFT We've removed the ZIPs from our repo, as |
@chenkennt @superyyrrzz @vwxyzh @hellosnow @ansyral