Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add net461 build target for common libararies #2482

Merged
merged 2 commits into from
Mar 5, 2018
Merged

Conversation

vicancy
Copy link
Contributor

@vicancy vicancy commented Mar 2, 2018

Fix #2358. As with netstandard libarary referenced, new version of System.Runtime.InteropServices.RuntimeInformation is introduced by build system with no way to turn around

@tzachshabtay
Copy link
Contributor

Hi @vicancy , can you explain the fix?
I have the same "MSBuildNameIgnoreCaseComparer" exception in my own application (unrelated to DocFX), and I'm trying to understand the issue and the fix, but nothing in your changes seem to actually mention "System.Runtime.InteropServices.RuntimeInformation".
How is adding net461 solves the problem?

@vicancy
Copy link
Contributor Author

vicancy commented Mar 5, 2018

Hi @tzachshabtay, in our case, it is that when net461 project A.csproj references netstandard2.0 project B.csproj, msbuild uses a newer version of System.Runtime.InteropServices.RuntimeInformation inside netcore2.0 sdk even if I specify a lower version in my A.csproj because this assembly is a MUST have assembly for netstandard project. Looks like this newer version of System.Runtime.InteropServices.RuntimeInformation is not supported by Mono, so as a workaround, I uses net461 all the way down.

@vicancy vicancy merged commit 01f70ee into dotnet:dev Mar 5, 2018
@vicancy vicancy deleted the bf branch March 5, 2018 02:00
@tzachshabtay
Copy link
Contributor

Thanks for the explanation @vicancy , is there an issue on Mono for this? Is this the issue? mono/mono#7011

@vicancy
Copy link
Contributor Author

vicancy commented Mar 7, 2018

@tzachshabtay yes that is! didn't find that one before, thanks for pointing that out.

@vicancy
Copy link
Contributor Author

vicancy commented Mar 7, 2018

Are you meeting the same issue @tzachshabtay ? does the workaround apply for you?

@tzachshabtay
Copy link
Contributor

@vicancy yes, I'm pretty sure I'm meeting the same issue. I haven't tried the workaround. As mono supposedly fixed the issue I think I'm going to wait for a version with the fix and try that first.

vicancy added a commit that referenced this pull request Mar 9, 2018
* Add net461 build for docfx.csproj

* fix build failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants