Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added delegate to resolve a cref in TripleSlashCommentModel. #2469

Merged
merged 1 commit into from
Mar 2, 2018

Conversation

surban
Copy link
Contributor

@surban surban commented Feb 27, 2018

  • Introduced ResolveCRef delegate in ITripleSlashCommentParserContext.
  • It is called when a cref attribute from an XML comment is to be
    resolved.
  • The delegate returns the name of a reference to the appropriate target.
  • Necessary for F# support, since the F# compiler does not resolve
    the cref attribute to comment ids in triple slash comments.

- Introduced ResolveCRef delegate in ITripleSlashCommentParserContext.
- It is called when a cref attribute from an XML comment is to be
  resolved.
- The delegate returns the name of a reference to the appropriate target.
- Necessary for F# support, since the F# compiler does not resolve
  the cref attribute to comment ids in triple slash comments.
- Introduced call to ResolveCrefLink for exceptions, since they need
  to be resolved as well.
@surban surban changed the base branch from master to dev March 1, 2018 10:48
@surban
Copy link
Contributor Author

surban commented Mar 1, 2018

Rebased to dev branch as requested.

Copy link
Contributor

@superyyrrzz superyyrrzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants