-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pack DfmHttpService #1167
Pack DfmHttpService #1167
Conversation
<requireLicenseAcceptance>true</requireLicenseAcceptance> | ||
<licenseUrl>https://github.com/dotnet/docfx/blob/dev/LICENSE</licenseUrl> | ||
<projectUrl>https://github.com/dotnet/docfx</projectUrl> | ||
<description>This is a tool to generate API documentation for .NET projects.</description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: do wee need to update the description?
src/nuspec/docfx.console/tools/*.dll | ||
src/nuspec/docfx.console/tools/*.exe | ||
src/nuspec/docfx.console/tools/*.exe.config | ||
src/nuspec/docfx.console/tools/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why ignoring everything in tools? install.ps1?
function PackSelfContainProject { | ||
param($sourceFolder, $nuspecPath) | ||
$targetFolder = (Get-Item $nuspecPath).Directory.FullName | ||
$null = New-Item -ItemType Directory -Force -Path "$targetFolder\tools\" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy to a target folder instead of doing it inside src folder $nuspecPath
@@ -60,6 +60,18 @@ function NugetPack { | |||
} | |||
} | |||
|
|||
function PackSelfContainProject { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PackSelfContainProject [](start = 9, length = 22)
PackSelfContainTool?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Project
here is better than Tool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit confusing with NugetPack... which also pack self contain project
In reply to: 95931418 [](ancestors = 95931418)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 similar comment
src/nuspec/docfx.console/tools/*.exe.config | ||
src/nuspec/AzureMarkdownRewriterTool/tools/ | ||
|
||
PACK/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PACK [](start = 0, length = 4)
reuse naming convention, e.g. DROP, TEMP, obj, ...
@@ -60,6 +60,31 @@ function NugetPack { | |||
} | |||
} | |||
|
|||
function PackSelfContainProject { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PackSelfContainProject [](start = 9, length = 22)
PackNuspecProject?
Copy-Item -Path "$assemblyFolder\*.exe" -Destination "$targetFolder\tools\" -Force | ||
Copy-Item -Path "$assemblyFolder\*.exe.config" -Destination "$targetFolder\tools\" -Force | ||
|
||
& $nuget pack "$targetFolder\$nuspecName" -Version $version -OutputDirectory artifacts\$configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$version [](start = 55, length = 8)
param implicitly used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.