Get `homebrew-add-package` artefact working

[dougbu]

While working on #436, found the homebrew-add-package fails because it executes brew as the helix-runner use (to avoid brew's failures when run as root). That user is not currently created until the first-run scripts are run, long after image generation completes.

We have previous hit problems attempting to automate brew execution and fell back to having DDFun install the few OS packages we need as part of their manual processes. Fixing this issue will enable a slight reduction in their workload.

Release Note Category

• Feature changes/additions
• Bug fixes
• Internal Infrastructure Improvements

Release Note Description

Corrected problems automating our use of HomeBrew when setting up macOS machines.

As part of this, the gnu-sed package will be installed on newly-created macOS machines (as gsed).

DDFun is likely close to wrapping up tickets for manual addition of these packages on all macOS systems but the work may not be quite complete at the time of this rollout. Feel free to check for (e.g., with $(command -v gsed)) and use gsed if you prefer to avoid BSD sed (the macOS default). The "check for" requirement (if it remains) should go away shortly.

[dougbu]

@ilyas1974 please either file follow-up issues to add those OS packages to our use of this artefact or list what we should install while fixing the artefact (perhaps bulking up the PR slightly).

Separately, does DDFun reimage our macOS machines on a regular basis❔ That is, will it take weeks or months before artefact changes affect all of our macOS on-prem boxes❔

[dougbu]

Suggestions appreciated for appropriate epic here. I was thinking of Ops - Service Maintenance but haven't convinced myself.

[dougbu]

Reviewed the DDFun instructions for setting up macOS systems. We currently ask them to install the following Homebrew packages:

• openssl
• openssl@1.1
• mono-libgdiplus
• llvm

Will include mono-libgdiplus in our automation while fixing this issue. Will also file a follow-up issue for the remainder of the above requirements; they require additional thought and work due to symlink creations and /etc/paths additions needed for each.

[dougbu]

Updated the release note based on an offline conversation w/ @ilyas1974 and his work over the "slow season" w/ DDFun to include gnu-sed on all macOS systems.

[dougbu]

Resolved w/ !35986