Skip to content

Retire legacy DumpGCData SOS script - #6104

Open
max-charlamb wants to merge 1 commit into
dotnet:mainfrom
max-charlamb:dev/max-charlamb/retire-dumpgcdata-script
Open

max-charlamb wants to merge 1 commit into
dotnet:mainfrom
max-charlamb:dev/max-charlamb/retire-dumpgcdata-script

Conversation

@max-charlamb

Copy link
Copy Markdown
Member

Summary

Retire DumpGCData.script and its legacy registration after migrating the pinning-statistics regression to the modern SOS suite.

  • Reuse the isolated DumpGCData debuggee with named unpinned and pinned stops and the existing snapshot helper.
  • Assert zero pinning data before allocation and a value of one after pinning a GCHandle and forcing collection.
  • Cover workstation GC live and both workstation/server GC in dumps through applicable native and dotnet-dump hosts. Preserve the existing Core-only scope; Framework and SingleFile are not added by this retirement.
  • Explicitly skip .NET 8/9 in SOSTestSkips, with the original fix linked: [DAC] fix dac_gc_heap marshalling runtime#119393.
  • Include the debuggee in the modern Helix payload catalog and update the coverage audit and README. No live-host GC wiring or CI pipeline changes.

Validation

Windows x64 local validation:

  • Targeted SOS.Tests and SOS.UnitTests builds passed.
  • 40 tests passed, including the five .NET 10 replacement configurations: CDB live workstation, and CDB/dotnet-dump dumps with workstation/server GC.
  • After simplifying the matrix and adding explicit skips: 5 .NET 10 cases passed and 10 .NET 8/9 cases skipped.

Linux/macOS, x86/ARM, and .NET 11 were not run locally.

@max-charlamb
max-charlamb requested a review from a team as a code owner October 10, 2026 17:27
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f17f240e-3383-4d72-a3bd-d4256d76c533
@max-charlamb
max-charlamb force-pushed the dev/max-charlamb/retire-dumpgcdata-script branch from afd640f to db831bf Compare October 10, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant