Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize TFM infrastructure #4971

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Oct 1, 2024

No description provided.

@hoyosjs hoyosjs requested a review from a team as a code owner October 1, 2024 06:52
@tommcdon
Copy link
Member

tommcdon commented Oct 1, 2024

It looks like SupportedSubrocessNetTargetFrameworks might contain a typo. Perhaps SupportedTargetFrameworks might work?

Copy link
Member

@mikem8361 mikem8361 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Tom about SupportedSubrocessNetTargetFrameworks. Either Subrocess -> SubProcess or something like Tom suggested

@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<OutputType>Library</OutputType>
<TargetFrameworks Condition="'$(DotNetBuildSourceOnly)' != 'true'">netstandard2.0;net6.0</TargetFrameworks>
<TargetFrameworks Condition="'$(DotNetBuildSourceOnly)' != 'true'">netstandard2.0;$(NetCoreAppMinTargetFramework)</TargetFrameworks>
<TargetFramework Condition="'$(DotNetBuildSourceOnly)' == 'true'">netstandard2.0</TargetFramework>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional? My understanding is that source-build cares less about netstandard compat than non-sourcebuild (which only matters if we want .net framework compat; name of this project suggests otherwise; .NETCore.Client).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NETCore.Client needs to support the lowest .NET version (net6.0) - sourcebuild has trouble with this since it doesn't have the 6.0 refpack available always.

Comment on lines +4 to 5
<TargetFrameworks Condition="'$(DotNetBuildSourceOnly)' != 'true'">netstandard2.0;$(NetCoreAppMinTargetFramework)</TargetFrameworks>
<TargetFramework Condition="'$(DotNetBuildSourceOnly)' == 'true'">netstandard2.0</TargetFramework>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IOW, who will be affected by:

Suggested change
<TargetFrameworks Condition="'$(DotNetBuildSourceOnly)' != 'true'">netstandard2.0;$(NetCoreAppMinTargetFramework)</TargetFrameworks>
<TargetFramework Condition="'$(DotNetBuildSourceOnly)' == 'true'">netstandard2.0</TargetFramework>
<TargetFramework>$(NetCoreAppMinTargetFramework)</TargetFramework>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are - and sourcebuild would. A lot of what lives in this repo is sadly stuck either in NS or has to be dual target. It also has to target the lowest netcoreapp version we have in support. And SB doesn't like that last bit - hence this.

@hoyosjs hoyosjs enabled auto-merge (squash) October 2, 2024 01:32
@hoyosjs hoyosjs merged commit f46a5cf into dotnet:main Oct 2, 2024
20 checks passed
@hoyosjs hoyosjs deleted the dev/juhoyosa/move-central-tfm branch October 2, 2024 18:03
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants