Add CLRMA support to SOS. #4437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the CLRMA exports on SOS.dll. Implement the CLRMA interfaces on top of ICrashInfoServices. Update ICrashInfoService to be more generic and not JSON crash info specific. Renamed IManagedException to IException. Add IStackFrame.GetMethodName replacing Offset/MethodName. Cleanup/change name of SOSHost.INativeClient Change TraceError used in extensions lib not to depend on SOS globals being initialized
noahfalk
reviewed
Jan 4, 2024
|
|
||
| namespace SOS.Extensions.Clrma | ||
| { | ||
| public sealed class ExceptionWrapper : COMCallableIUnknown |
Member
There was a problem hiding this comment.
Do we need to put a managed<->native marshalling layer into SOS for this? My understanding was that CLRMA was able to interact with CLRMD directly using its managed API - couldn't we do the same when it interacts with SOS?
Contributor
Author
There was a problem hiding this comment.
The CLRMA interfaces are all C++/COM. There was an managed C++ interop wrapper dll and C# provider that used CLRMD but it was abandoned and removed. It seemed a lot simpler to just do the interop myself since SOS already does this a lot.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the CLRMA exports on SOS.dll. Implement the CLRMA interfaces on top of ICrashInfoServices.
Update ICrashInfoService to be more generic and not JSON crash info specific.
Renamed IManagedException to IException.
Add IStackFrame.GetMethodName replacing Offset/MethodName.
Cleanup/change name of SOSHost.INativeClient
Change TraceError used in extensions lib not to depend on SOS globals being initialized