validate that providers are > 0 to provide clear error when using Diagnostics Client #4411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s thrown and it's not clear what the issue is.
Contributor
Author
|
Thanks @davmason I didn't see any unit tests validating the ctor arguments so I didn't add any, but happy to follow any guidelines you have. |
Contributor
|
I don't think we need any tests here, thanks for the fix! |
Contributor
Author
Thank you and thanks for all the work you and the team do! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validate that providers are > 0 otherwise START Failed 0x80131384 get…s thrown and it's not clear what the issue is.
The current behavior when an empty list of providers is provided is to throw START Failed 0x80131384 (BadEncoding) and that doesn't make it very clear about what the issue is. This PR proposes validating the number of providers so developers know that they should be providing 1 provider at least.
Before:
After:
