Restore error message when the heap isn't walkable #4361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!dumpheap and !verifyheap used to warn you that the GC Heap was not walkable. That error was lost when I converted the code from C++ to C#. Added a way to override the error so that it doesn't become blocking when we still want to validate or dump the parts of the heap that we can.
mikem8361
approved these changes
Oct 24, 2023
Contributor
|
I'm doing a 8.0 tools release. I've done the snap but if you think this is important enough, I can take it. |
Contributor
Author
|
Nope, not important. It can wait for the next train. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!dumpheap and !verifyheap used to warn you that the GC Heap was not walkable. That error was lost when I converted the code from C++ to C#.
Added a way to override the error so that it doesn't become blocking when we still want to validate or dump the parts of the heap that we can.