Skip to content

Fix ModuleLoadUnloadTraceData.ModuleID cast to be unchecked since its really a ulong member. #4354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hoyosjs merged 1 commit into from
Oct 23, 2023
Merged

Fix ModuleLoadUnloadTraceData.ModuleID cast to be unchecked since its really a ulong member. #4354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Tools/dotnet-gcdump/DotNetHeapDump/DotNetHeapDumpGraphReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,12 +117,13 @@ internal void SetupCallbacks(MemoryGraph memoryGraph, TraceEventDispatcher sourc
return;
}

if (!m_moduleID2Name.ContainsKey((ulong)data.ModuleID))
ulong moduleID = unchecked((ulong)data.ModuleID);
if (!m_moduleID2Name.ContainsKey(moduleID))
{
m_moduleID2Name[(ulong)data.ModuleID] = data.ModuleILPath;
m_moduleID2Name[moduleID] = data.ModuleILPath;
}

m_log.WriteLine("Found Module {0} ID 0x{1:x}", data.ModuleILFileName, (ulong)data.ModuleID);
m_log.WriteLine("Found Module {0} ID 0x{1:x}", data.ModuleILFileName, moduleID);
};
source.Clr.AddCallbackForEvents(moduleCallback); // Get module events for clr provider
// TODO should not be needed if we use CAPTURE_STATE when collecting.
Expand Down