Port targetted fixes to release #3812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hoyosjs
commented
Apr 11, 2023
hoyosjs
commented
- Fix IndexOutOfRangeException (Fix IndexOutOfRangeException #3800)
- Update ClrMD version (Update ClrMD version #3804)
- Add !dumpheap fragmentation statistics (Add !dumpheap fragmentation statistics #3799)
* Fix IndexOutOfRangeException Fix an IndexOutOfRangeException with !sos maddress. * Add initial parts length check * One more fix
I moved the the "Generation" enum to ClrMD itself. It's far more useful (and accurate) to talk about an object's generation as a member of an enum which describes it rather than a simple integer. This change flowed through the SOS commands which used ClrSegment.GetGeneration. I manually tested all commands affected.
In my previous !dumpheap change I overlooked the fragmentation output. This adds fragmentation output in the exact same was as the previous C++ code. The new code now validates the Free region is actually followed by the next object, and that those objects do not live on the Pinned, Frozen, or Large object heaps.
mikem8361
approved these changes
Apr 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.