Fix EventPipeProvider to enable listening to events without keyword #1091
Conversation
| @@ -12,7 +12,7 @@ namespace Microsoft.Diagnostics.NETCore.Client | |||
| { | |||
| public sealed class EventPipeProvider | |||
| { | |||
| public EventPipeProvider(string name, EventLevel eventLevel, long keywords = 0, IDictionary<string, string> arguments = null) | |||
| public EventPipeProvider(string name, EventLevel eventLevel, long keywords = 0xF00000000000, IDictionary<string, string> arguments = null) | |||
There was a problem hiding this comment.
Out of curiosity, what does 0xF00000000000 represent?
There was a problem hiding this comment.
that should map to https://github.com/dotnet/diagnostics/blob/master/documentation/dotnet-trace-instructions.md, right? I always used Fs to get everything.
There was a problem hiding this comment.
This is keyword that gets appended to Events that are written without any keywords specified.
For example you won't be able to listen to the events written in the following EventSource by default.
public class MyEventSource : EventSource
{
public static MyEventSource Log = new MyEventSource();
public void Event1() { WriteEvent(1); }
public void Event2(string fileName) { WriteEvent(2, fileName); }
public void Event3() { WriteEvent(3); }
}
With this change the simplest set of EventPipeProvider is just new EventPipeProvider("MyEventSource", EventLevel.Informational).
This is also the default behavior of EventListener.EnableEvents() which is what this API was meant to correspond with.
No, this is enabling just events that are written without any keywords. |
There was a problem hiding this comment.
Is this enabling all events on the provider?
No, this is enabling just events that are written without any keywords.
Okay. Based on the conversation in #1062 I'm guessing this is to match the default behavior of EventListener.
Effectively this change is making the default be to enable any events w/o a keyword if no keyword is specified. I think that is acceptable behavior. LGTM
Fix #1062.
0xF00000000000