Windbg SOS truncates symbol path to 260 characters

[Zhentar]

InitializeSymbolStoreFromSymPath assumes that sympath cannot be longer than 260 characters. This is.... not at all accurate.

diagnostics/src/SOS/Strike/hostcoreclr.cpp

Lines 825 to 830 in 16ae730

	void InitializeSymbolStoreFromSymPath()
	{
	if (g_SOSNetCoreCallbacks.InitializeSymbolStoreDelegate != nullptr)
	{
	ArrayHolder<char> symbolPath = new char[MAX_LONGPATH];
	if (SUCCEEDED(g_ExtSymbols->GetSymbolPath(symbolPath, MAX_LONGPATH, nullptr)))

[mikem8361]

I need to remove the MAX_LONGPATH definition in palclr.h. The actual definition is in pal.h line 121 and it is 1024 chars.

[Zhentar]

While that's better, it still doesn't completely solve the problem; my "minimal" sympath has two http URLs and 4 UNC paths in it, and each one of those is individually allowed to be longer than 1024 characters

[mikem8361]

PR: #690