Fix handling of empty 'urlsToWatch' in plugins

[SilentSobs]

Issue #527

This commit resolves an issue where plugins defining an empty array for 'urlsToWatch' would result in the plugin being disabled. The code has been modified to check for both null and empty arrays, and in both cases, it now defaults to using the global list of URLs. This ensures that plugins remain active even when no specific URLs are provided.

• Modified the code to handle empty 'urlsToWatch' arrays.
• Added a check for both null and empty arrays.
• Plugins now default to using the global list of URLs when 'urlsToWatch' is empty.

Let's confirm this:

{
  "$schema": "https://raw.githubusercontent.com/microsoft/dev-proxy/main/schemas/v0.15.0/rc.schema.json",
  "plugins": [
    {
      "name": "RetryAfterPlugin",
      "enabled": true,
      "pluginPath": "plugins\\dev-proxy-plugins.dll"
    },
    {
      "name": "GenericRandomErrorPlugin",
      "enabled": true,
      "pluginPath": "plugins\\dev-proxy-plugins.dll",
      "configSection": "genericRandomErrorPlugin",
      "urlsToWatch": []  // Empty array indicates that it now defaults to using the global list of URLs
    }
  ],
  "urlsToWatch": [
    "https://jsonplaceholder.typicode.com/*"
  ],
  "genericRandomErrorPlugin": {
    "errorsFile": "devproxy-errors.json"
  },
  "rate": 50,
  "labelMode": "text",
  "logLevel": "info",
  "newVersionNotification": "stable"
}

As you can see, I have added a comment to the urlsToWatch array in the GenericRandomErrorPlugin block to explicitly state that the empty array indicates that it now defaults to using the global list of URLs. This helps in providing a clear and concise explanation of the purpose of the empty array.

Now let's test

Now let's change it

{
  "$schema": "https://raw.githubusercontent.com/microsoft/dev-proxy/main/schemas/v0.15.0/rc.schema.json",
  "plugins": [
    {
      "name": "RetryAfterPlugin",
      "enabled": true,
      "pluginPath": "plugins\\dev-proxy-plugins.dll",
      "urlsToWatch": []  // Empty array indicates that it now defaults to using the global list of URLs
    },
    {
      "name": "GenericRandomErrorPlugin",
      "enabled": true,
      "pluginPath": "plugins\\dev-proxy-plugins.dll",
      "configSection": "genericRandomErrorPlugin",
   
    }

Ealier Code

plugin.Register(pluginEvents, proxyContext, pluginUrls ?? defaultUrlsToWatch, h.ConfigSection is null ? null : Configuration.GetSection(h.ConfigSection));

Changes Made:

plugin.Register(
    pluginEvents,
    proxyContext,
    (pluginUrls != null && pluginUrls.Count > 0) ? pluginUrls : defaultUrlsToWatch,
    h.ConfigSection is null ? null : Configuration.GetSection(h.ConfigSection)
);

[waldekmastykarz]

Almost there. Let's do one small adjustment and we'll merge it in. We appreciate your help