-
Notifications
You must be signed in to change notification settings - Fork 79
Normalize enum names to lowercase in graphminimalpermissionsplugin schema #1524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,8 +9,8 @@ | |
| "type": { | ||
| "type": "string", | ||
| "enum": [ | ||
| "Delegated", | ||
| "Application" | ||
| "delegated", | ||
| "application" | ||
| ] | ||
| } | ||
| }, | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -9,8 +9,8 @@ | |||||||||
| "type": { | ||||||||||
| "type": "string", | ||||||||||
| "enum": [ | ||||||||||
| "Delegated", | ||||||||||
| "Application" | ||||||||||
| "delegated", | ||||||||||
| "application" | ||||||||||
|
||||||||||
| "application" | |
| "Delegated", | |
| "application", | |
| "Application" |
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -10,10 +10,10 @@ | |||||||||
| "type": { | ||||||||||
| "type": "string", | ||||||||||
| "enum": [ | ||||||||||
| "Delegated", | ||||||||||
| "Application" | ||||||||||
| "delegated", | ||||||||||
| "application" | ||||||||||
|
||||||||||
| "application" | |
| "Delegated", | |
| "application", | |
| "Application" |
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -10,10 +10,10 @@ | |||||||||
| "type": { | ||||||||||
| "type": "string", | ||||||||||
| "enum": [ | ||||||||||
| "Delegated", | ||||||||||
| "Application" | ||||||||||
| "delegated", | ||||||||||
| "application" | ||||||||||
|
||||||||||
| "application" | |
| "application", | |
| "Delegated", | |
| "Application" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,10 +10,10 @@ | |
| "type": { | ||
| "type": "string", | ||
| "enum": [ | ||
| "Delegated", | ||
| "Application" | ||
| "delegated", | ||
| "application" | ||
| ], | ||
| "description": "Determines which type of permission scopes to return. Can be 'Delegated' or 'Application'. Default: 'Delegated'." | ||
| "description": "Determines which type of permission scopes to return. Can be 'delegated' or 'application'. Default: 'delegated'." | ||
|
Comment on lines
12
to
+16
|
||
| } | ||
| }, | ||
| "additionalProperties": false | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -10,10 +10,10 @@ | |||||||||
| "type": { | ||||||||||
| "type": "string", | ||||||||||
| "enum": [ | ||||||||||
| "Delegated", | ||||||||||
| "Application" | ||||||||||
| "delegated", | ||||||||||
| "application" | ||||||||||
|
||||||||||
| "application" | |
| "application", | |
| "Delegated", | |
| "Application" |
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -10,10 +10,10 @@ | |||||||||
| "type": { | ||||||||||
| "type": "string", | ||||||||||
| "enum": [ | ||||||||||
| "Delegated", | ||||||||||
| "Application" | ||||||||||
| "delegated", | ||||||||||
| "application" | ||||||||||
|
||||||||||
| "application" | |
| "Delegated", | |
| "application", | |
| "Application" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,10 +10,10 @@ | |
| "type": { | ||
| "type": "string", | ||
| "enum": [ | ||
| "Delegated", | ||
| "Application" | ||
| "delegated", | ||
| "application" | ||
| ], | ||
| "description": "Determines which type of permission scopes to return. Can be 'Delegated' or 'Application'. Default: 'Delegated'." | ||
| "description": "Determines which type of permission scopes to return. Can be 'delegated' or 'application'. Default: 'delegated'." | ||
|
Comment on lines
12
to
+16
|
||
| } | ||
| }, | ||
| "additionalProperties": false | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -10,10 +10,10 @@ | |||||||||
| "type": { | ||||||||||
| "type": "string", | ||||||||||
| "enum": [ | ||||||||||
| "Delegated", | ||||||||||
| "Application" | ||||||||||
| "delegated", | ||||||||||
| "application" | ||||||||||
|
||||||||||
| "application" | |
| "Delegated", | |
| "application", | |
| "Application" |
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -10,10 +10,10 @@ | |||||||||
| "type": { | ||||||||||
| "type": "string", | ||||||||||
| "enum": [ | ||||||||||
| "Delegated", | ||||||||||
| "Application" | ||||||||||
| "delegated", | ||||||||||
| "application" | ||||||||||
|
||||||||||
| "application" | |
| "Delegated", | |
| "application", | |
| "Application" |
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -10,10 +10,10 @@ | |||||||||
| "type": { | ||||||||||
| "type": "string", | ||||||||||
| "enum": [ | ||||||||||
| "Delegated", | ||||||||||
| "Application" | ||||||||||
| "delegated", | ||||||||||
| "application" | ||||||||||
|
||||||||||
| "application" | |
| "Delegated", | |
| "application", | |
| "Application" |
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -10,10 +10,10 @@ | |||||||||
| "type": { | ||||||||||
| "type": "string", | ||||||||||
| "enum": [ | ||||||||||
| "Delegated", | ||||||||||
| "Application" | ||||||||||
| "delegated", | ||||||||||
| "application" | ||||||||||
|
||||||||||
| "application" | |
| "Delegated", | |
| "application", | |
| "Application" |
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -10,10 +10,10 @@ | |||||||||
| "type": { | ||||||||||
| "type": "string", | ||||||||||
| "enum": [ | ||||||||||
| "Delegated", | ||||||||||
| "Application" | ||||||||||
| "delegated", | ||||||||||
| "application" | ||||||||||
|
||||||||||
| "application" | |
| "Delegated", | |
| "application", | |
| "Application" |
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -10,10 +10,10 @@ | |||||||||
| "type": { | ||||||||||
| "type": "string", | ||||||||||
| "enum": [ | ||||||||||
| "Delegated", | ||||||||||
| "Application" | ||||||||||
| "delegated", | ||||||||||
| "application" | ||||||||||
|
||||||||||
| "application" | |
| "application", | |
| "Delegated", | |
| "Application" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The schema enum now only permits lowercase values ('delegated'/'application'). This is a breaking change for configs (and editor validation) that still use the previously-documented 'Delegated'/'Application' values, especially for people pinning older schema URLs. Consider allowing both casings in the enum (or introducing a new schema version and leaving historical schemas unchanged).