Fixes concurrency issue in ProxyEngine, ConcolFormatter, and MockResponsePlugin #1161 #1162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dotnet-policy-service agree |
Collaborator
|
Cool! We'll check it out asap! Thank you for such a quick turnaround and your contribution. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a concurrency issue by replacing standard dictionaries with thread-safe ConcurrentDictionary instances across multiple components. Key changes include updating the storage for plugin data in ProxyEngine, modifying the request log buffering in ProxyConsoleFormatter, and fixing update logic in MockResponsePlugin.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| dev-proxy/ProxyEngine.cs | Replaces Dictionary with ConcurrentDictionary and adds error handling |
| dev-proxy/Logging/ProxyConsoleFormatter.cs | Updates Dictionary to ConcurrentDictionary and uses GetOrAdd |
| dev-proxy-plugins/Mocks/MockResponsePlugin.cs | Changes Dictionary to ConcurrentDictionary and leverages AddOrUpdate |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
waldekmastykarz
approved these changes
May 5, 2025
Collaborator
waldekmastykarz
left a comment
waldekmastykarz
left a comment
There was a problem hiding this comment.
Works like a charm! Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a suggestion to fix #1161