-
Notifications
You must be signed in to change notification settings - Fork 166
Update BinaryFormatter obsoletion plan for net8 #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Would this include corresponding changes for roslyn-analyzers and the IIRC serialization code is still included in the snippet, and omitting those functions can trigger CA2237 and CA2229 (which would be conflicting with SYSLIB0050). |
@yaakov-h CA2237 and CA2229 are still useful. If you do still need to implement The |
I see that Orleans respects |
Yes. I'm not aware of any plans to deprecate or hide this API. |
The whole code snippet infrastructure need an update. A lot portion of them are only applicable to C# 2.0-4.0. Please push a feature request to the owners! |
De-conflict against new warning codes introduced during JSON work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated plan looks good to me. I just have one suggestion for getting rid of an "I" statement.
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
- Move BinaryFormatter obsoletions to type-level - Introduce SYSLIB0050 and SYSLIB0051 obsoletion waves - Remove some dead code Ref: dotnet/designs#293
Updating the list of obsoletions for .NET 8, bringing a few more in and pushing some out to .NET 9.
The primary reason for doing this is to provide a better experience for developers. Compared to the original plan, this should result in fewer overall warnings being observed, and the warnings which are observed should be more directly actionable.