Skip to content

Modify compiler options for overflow and aliasing #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2025
Merged

Modify compiler options for overflow and aliasing #507

merged 1 commit into from
Oct 27, 2025

Conversation

@AaronRobinsonMSFT
Copy link
Member

Updated compiler options to improve signed overflow handling and suppress strict aliasing rules.

See related code for dotnet/runtime#120775

@AaronRobinsonMSFT
Modify compiler options for overflow and aliasing
19211f0 
Updated compiler options to improve signed overflow handling and suppress strict aliasing rules.

See related code for dotnet/runtime#120775
@AaronRobinsonMSFT AaronRobinsonMSFT requested a review from a team as a code owner October 27, 2025 21:09
@AaronRobinsonMSFT
Copy link
Member Author

This code needs to be ported to the .NET 10 branch as well. Please let me know the process.

@NikolaMilosavljevic
Copy link
Member

This code needs to be ported to the .NET 10 branch as well. Please let me know the process.

We don't have a 10.0 branch which would be for servicing only. Once this is merged I will fork for 10.0 for the future release of the NetCoreCheck packages. That's the only package in this repo that uses c++.

@AaronRobinsonMSFT
Copy link
Member Author

This code needs to be ported to the .NET 10 branch as well. Please let me know the process.

We don't have a 10.0 branch which would be for servicing only. Once this is merged I will fork for 10.0 for the future release of the NetCoreCheck packages. That's the only package in this repo that uses c++.

Thanks @NikolaMilosavljevic . This looks all green now. Should I merge it?

@NikolaMilosavljevic NikolaMilosavljevic merged commit 84ccc05 into main Oct 27, 2025
9 checks passed
@dotnet-maestro dotnet-maestro bot mentioned this pull request Oct 27, 2025
Merged
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the AaronRobinsonMSFT-patch-1 branch October 27, 2025 22:40
@AaronRobinsonMSFT AaronRobinsonMSFT mentioned this pull request Oct 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkotas jkotas jkotas approved these changes

@NikolaMilosavljevic NikolaMilosavljevic NikolaMilosavljevic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AaronRobinsonMSFT @NikolaMilosavljevic @jkotas