Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The compiler -> a compiler #1226

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Conversation

BillWagner
Copy link
Member

Search for instances of "the compiler" and where the text describes what a compliant compiler is is required or allowed to do, replace "the compiler" with "a compiler". Where necessary, include "shall" or "may", as appropriate.

There are still instances of "the compiler" in the standard. Some are in types.md. Those are addressed in #1125. Others are where the text describes "the compiler generated" backing field, class, or method.

Search for instances of "the compiler" and where the text describes what a compliant compiler is is required or allowed to do, replace "the compiler" with "a compiler".  Where necessary, include "shall" or "may", as appropriate.

There are still instances of "the compiler" in the standard. Some are in types.md. Those are addressed in dotnet#1125.  Others are where the text describes "the compiler generated" backing field, class, or method.
@BillWagner BillWagner added the meeting: discuss This issue should be discussed at the next TC49-TG2 meeting label Dec 4, 2024
standard/statements.md Outdated Show resolved Hide resolved
Copy link
Contributor

@RexJaeschke RexJaeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bill, I fixed one typo; otherwise, it all looks good.

Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfectly happy with the general thrust, but a few nits.

standard/classes.md Outdated Show resolved Hide resolved
standard/classes.md Outdated Show resolved Hide resolved
standard/classes.md Outdated Show resolved Hide resolved
standard/classes.md Outdated Show resolved Hide resolved
standard/variables.md Outdated Show resolved Hide resolved
standard/classes.md Outdated Show resolved Hide resolved
jskeet and others added 2 commits December 11, 2024 20:12
Co-authored-by: Nigel-Ecma <6654683+Nigel-Ecma@users.noreply.github.com>
Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
@BillWagner BillWagner merged commit 80ffac8 into dotnet:draft-v8 Dec 11, 2024
6 checks passed
@BillWagner BillWagner deleted the its-a-compiler branch December 11, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meeting: discuss This issue should be discussed at the next TC49-TG2 meeting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants