-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The compiler -> a compiler #1226
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Search for instances of "the compiler" and where the text describes what a compliant compiler is is required or allowed to do, replace "the compiler" with "a compiler". Where necessary, include "shall" or "may", as appropriate. There are still instances of "the compiler" in the standard. Some are in types.md. Those are addressed in dotnet#1125. Others are where the text describes "the compiler generated" backing field, class, or method.
BillWagner
added
the
meeting: discuss
This issue should be discussed at the next TC49-TG2 meeting
label
Dec 4, 2024
RexJaeschke
reviewed
Dec 4, 2024
RexJaeschke
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bill, I fixed one typo; otherwise, it all looks good.
jskeet
reviewed
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfectly happy with the general thrust, but a few nits.
Nigel-Ecma
reviewed
Dec 10, 2024
Co-authored-by: Nigel-Ecma <6654683+Nigel-Ecma@users.noreply.github.com>
Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
jskeet
approved these changes
Dec 11, 2024
gafter
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Search for instances of "the compiler" and where the text describes what a compliant compiler is is required or allowed to do, replace "the compiler" with "a compiler". Where necessary, include "shall" or "may", as appropriate.
There are still instances of "the compiler" in the standard. Some are in types.md. Those are addressed in #1125. Others are where the text describes "the compiler generated" backing field, class, or method.