Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate parameter-kinds text w.r.t Variables and Classes clauses #1174

Merged
merged 5 commits into from
Sep 16, 2024
Merged

Consolidate parameter-kinds text w.r.t Variables and Classes clauses #1174

merged 5 commits into from
Sep 16, 2024

Conversation

RexJaeschke
Copy link
Contributor

Instead of starting with only one of the 4 parameter kinds, the solution was found to be much simpler than first thought, so I addressed all 4.

This PR address all the concerns of Issue #1160.

  1. Variables subclauses 9.x cover lifetime, (sometimes) initialization, and definite assignment. All other text was moved to the Classes 15.x counterpart places with forward pointers to them, including the definitions of the terms value/input/output/reference parameters.
  2. Classes subclauses 15.x now point back to their 9.x counterpart places w.r.t definite assignment.
  3. Various links were updated due to the 9.x-->15.x move.

@RexJaeschke RexJaeschke requested a review from jskeet September 13, 2024 21:14
jskeet
jskeet reviewed Sep 16, 2024
View reviewed changes
standard/classes.md Outdated Show resolved Hide resolved
BillWagner
BillWagner approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM as well. Let's :shipit:

@RexJaeschke RexJaeschke merged commit 1d16ec2 into dotnet:draft-v8 Sep 16, 2024
7 checks passed
@RexJaeschke RexJaeschke deleted the cleanup-parameter-kinds branch September 16, 2024 13:50
@RexJaeschke RexJaeschke mentioned this pull request Sep 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskeet jskeet jskeet approved these changes

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RexJaeschke @jskeet @BillWagner