Update default interface method spec per LDM decisions #2215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logerfo
reviewed
Mar 4, 2019
| @@ -279,16 +259,10 @@ interface IC : IA | |||
|
|
|||
| class D : IA, IB, IC | |||
| { | |||
| void IA.M() { IB.base.M(); } | |||
| void IA.M() { base(IB).M(); } | |||
There was a problem hiding this comment.
Shouldn't the line 238 also be changed in order to reflect the new base call syntax?
There was a problem hiding this comment.
Sorry, I reviewed this before the merge, but forgot to submit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving closed issues to the specification.
/cc @MadsTorgersen @AlekseyTs @jaredpar